Skip to content

Address Safer CPP warnings about retainable members in Source/WebKit on iOS#57843

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:306929_retainable_members_ios_safer_cpp
Feb 4, 2026
Merged

Address Safer CPP warnings about retainable members in Source/WebKit on iOS#57843
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:306929_retainable_members_ios_safer_cpp

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Feb 4, 2026

9ca92cf

Address Safer CPP warnings about retainable members in Source/WebKit on iOS
https://bugs.webkit.org/show_bug.cgi?id=306929

Reviewed by Geoffrey Garen.

* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm:
(-[WKDisplayLinkHandler initWithDrawingAreaProxy:]):
(-[WKDisplayLinkHandler invalidate]):
(-[WKDisplayLinkHandler schedule]):
(-[WKDisplayLinkHandler pause]):
(-[WKDisplayLinkHandler nominalFramesPerSecond]):
(-[WKDisplayLinkHandler updateFrameRate]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKTextRange dealloc]):
(-[WKTextRange selectionRects]):
(-[WKTextRange setSelectionRects:]):
* Source/WebKit/UIProcess/ios/WKImageAnalysisGestureRecognizer.mm:
(-[WKImageAnalysisGestureRecognizer lastTouchedScrollView]):
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollViewDelegateForwarder methodSignatureForSelector:]):
(-[WKScrollViewDelegateForwarder respondsToSelector:]):
(-[WKScrollViewDelegateForwarder forwardInvocation:]):
(-[WKScrollViewDelegateForwarder forwardingTargetForSelector:]):
(-[WKScrollView internalDelegate]):
(-[WKScrollView setInternalDelegate:]):
(-[WKScrollView _updateDelegate]):
(-[WKScrollView setBackgroundColor:]):
(-[WKScrollView _setBackgroundColorInternal:]):
(-[WKScrollView setIndicatorStyle:]):
(-[WKScrollView setContentInset:]):
(-[WKScrollView _resetContentInset]):
(-[WKScrollView setContentInsetAdjustmentBehavior:]):
(-[WKScrollView _systemContentInset]):
(-[WKScrollView hitTest:withEvent:]):
(-[WKScrollView _didChangeTopScrollEdgeEffectStyle]):
* Source/WebKit/UIProcess/ios/WKUSDPreviewView.mm:
(-[WKUSDPreviewView web_setContentProviderData:suggestedFilename:completionHandler:]):
(-[WKUSDPreviewView _layoutThumbnailView]):
(-[WKUSDPreviewView thumbnailView:wantsToPresentPreviewController:forItem:]):
(-[WKUSDPreviewView web_countStringMatches:options:maxCount:]):
(-[WKUSDPreviewView web_findString:options:maxCount:]):
* Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
* Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(WebKit::WebDataListSuggestionsDropdownIOS::show):
* Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker initWithView:inputType:]):
(-[WKDateTimePicker datePickerPopoverControllerDidReset:]):
(-[WKDateTimePicker handleDatePickerPresentationDismissal]):
(-[WKDateTimePicker removeDatePickerPresentation]):
(-[WKDateTimePicker showDateTimePicker]):
(-[WKDateTimePicker shouldForceGregorianCalendar]):
(-[WKDateTimePicker _sanitizeInputValueForFormatter:]):
(-[WKDateTimePicker dateFormatterForPicker]):
(-[WKDateTimePicker _dateChanged]):
(-[WKDateTimePicker setDateTimePickerToInitialValue]):
(-[WKDateTimePicker controlBeginEditing]):
(-[WKDateTimePicker controlEndEditing]):
* Source/WebKit/UIProcess/ios/forms/WKFormPeripheralBase.mm:
(-[WKFormPeripheralBase view]):
* Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectTableViewController findItemIndexAt:]):
(-[WKSelectTableViewController findItemAt:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]):
(-[WKSelectTableViewController shouldDismissWithAnimation]):
(-[WKSelectTableViewController popover]):
(-[WKSelectTableViewController setPopover:]):

Canonical link: https://commits.webkit.org/306807@main

25b26da

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Feb 4, 2026
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Feb 4, 2026
@cdumez cdumez force-pushed the 306929_retainable_members_ios_safer_cpp branch from 4bbe5a5 to 25b26da Compare February 4, 2026 12:47
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Feb 4, 2026
…on iOS

https://bugs.webkit.org/show_bug.cgi?id=306929

Reviewed by Geoffrey Garen.

* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm:
(-[WKDisplayLinkHandler initWithDrawingAreaProxy:]):
(-[WKDisplayLinkHandler invalidate]):
(-[WKDisplayLinkHandler schedule]):
(-[WKDisplayLinkHandler pause]):
(-[WKDisplayLinkHandler nominalFramesPerSecond]):
(-[WKDisplayLinkHandler updateFrameRate]):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKTextRange dealloc]):
(-[WKTextRange selectionRects]):
(-[WKTextRange setSelectionRects:]):
* Source/WebKit/UIProcess/ios/WKImageAnalysisGestureRecognizer.mm:
(-[WKImageAnalysisGestureRecognizer lastTouchedScrollView]):
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollViewDelegateForwarder methodSignatureForSelector:]):
(-[WKScrollViewDelegateForwarder respondsToSelector:]):
(-[WKScrollViewDelegateForwarder forwardInvocation:]):
(-[WKScrollViewDelegateForwarder forwardingTargetForSelector:]):
(-[WKScrollView internalDelegate]):
(-[WKScrollView setInternalDelegate:]):
(-[WKScrollView _updateDelegate]):
(-[WKScrollView setBackgroundColor:]):
(-[WKScrollView _setBackgroundColorInternal:]):
(-[WKScrollView setIndicatorStyle:]):
(-[WKScrollView setContentInset:]):
(-[WKScrollView _resetContentInset]):
(-[WKScrollView setContentInsetAdjustmentBehavior:]):
(-[WKScrollView _systemContentInset]):
(-[WKScrollView hitTest:withEvent:]):
(-[WKScrollView _didChangeTopScrollEdgeEffectStyle]):
* Source/WebKit/UIProcess/ios/WKUSDPreviewView.mm:
(-[WKUSDPreviewView web_setContentProviderData:suggestedFilename:completionHandler:]):
(-[WKUSDPreviewView _layoutThumbnailView]):
(-[WKUSDPreviewView thumbnailView:wantsToPresentPreviewController:forItem:]):
(-[WKUSDPreviewView web_countStringMatches:options:maxCount:]):
(-[WKUSDPreviewView web_findString:options:maxCount:]):
* Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.h:
* Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(WebKit::WebDataListSuggestionsDropdownIOS::show):
* Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker initWithView:inputType:]):
(-[WKDateTimePicker datePickerPopoverControllerDidReset:]):
(-[WKDateTimePicker handleDatePickerPresentationDismissal]):
(-[WKDateTimePicker removeDatePickerPresentation]):
(-[WKDateTimePicker showDateTimePicker]):
(-[WKDateTimePicker shouldForceGregorianCalendar]):
(-[WKDateTimePicker _sanitizeInputValueForFormatter:]):
(-[WKDateTimePicker dateFormatterForPicker]):
(-[WKDateTimePicker _dateChanged]):
(-[WKDateTimePicker setDateTimePickerToInitialValue]):
(-[WKDateTimePicker controlBeginEditing]):
(-[WKDateTimePicker controlEndEditing]):
* Source/WebKit/UIProcess/ios/forms/WKFormPeripheralBase.mm:
(-[WKFormPeripheralBase view]):
* Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectTableViewController findItemIndexAt:]):
(-[WKSelectTableViewController findItemAt:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]):
(-[WKSelectTableViewController shouldDismissWithAnimation]):
(-[WKSelectTableViewController popover]):
(-[WKSelectTableViewController setPopover:]):

Canonical link: https://commits.webkit.org/306807@main
@webkit-commit-queue webkit-commit-queue force-pushed the 306929_retainable_members_ios_safer_cpp branch from 25b26da to 9ca92cf Compare February 4, 2026 21:51
@webkit-commit-queue
Copy link
Collaborator

Committed 306807@main (9ca92cf): https://commits.webkit.org/306807@main

Reviewed commits have been landed. Closing PR #57843 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9ca92cf into WebKit:main Feb 4, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit2 Bugs relating to the WebKit2 API layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants