Address Safer CPP warnings about retainable members in Source/WebKit on iOS#57843
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 4, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 4bbe5a5) Details |
4bbe5a5 to
25b26da
Compare
Collaborator
|
EWS run on current version of this PR (hash 25b26da) Details |
geoffreygaren
approved these changes
Feb 4, 2026
…on iOS https://bugs.webkit.org/show_bug.cgi?id=306929 Reviewed by Geoffrey Garen. * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm: (-[WKDisplayLinkHandler initWithDrawingAreaProxy:]): (-[WKDisplayLinkHandler invalidate]): (-[WKDisplayLinkHandler schedule]): (-[WKDisplayLinkHandler pause]): (-[WKDisplayLinkHandler nominalFramesPerSecond]): (-[WKDisplayLinkHandler updateFrameRate]): * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKTextRange dealloc]): (-[WKTextRange selectionRects]): (-[WKTextRange setSelectionRects:]): * Source/WebKit/UIProcess/ios/WKImageAnalysisGestureRecognizer.mm: (-[WKImageAnalysisGestureRecognizer lastTouchedScrollView]): * Source/WebKit/UIProcess/ios/WKScrollView.mm: (-[WKScrollViewDelegateForwarder methodSignatureForSelector:]): (-[WKScrollViewDelegateForwarder respondsToSelector:]): (-[WKScrollViewDelegateForwarder forwardInvocation:]): (-[WKScrollViewDelegateForwarder forwardingTargetForSelector:]): (-[WKScrollView internalDelegate]): (-[WKScrollView setInternalDelegate:]): (-[WKScrollView _updateDelegate]): (-[WKScrollView setBackgroundColor:]): (-[WKScrollView _setBackgroundColorInternal:]): (-[WKScrollView setIndicatorStyle:]): (-[WKScrollView setContentInset:]): (-[WKScrollView _resetContentInset]): (-[WKScrollView setContentInsetAdjustmentBehavior:]): (-[WKScrollView _systemContentInset]): (-[WKScrollView hitTest:withEvent:]): (-[WKScrollView _didChangeTopScrollEdgeEffectStyle]): * Source/WebKit/UIProcess/ios/WKUSDPreviewView.mm: (-[WKUSDPreviewView web_setContentProviderData:suggestedFilename:completionHandler:]): (-[WKUSDPreviewView _layoutThumbnailView]): (-[WKUSDPreviewView thumbnailView:wantsToPresentPreviewController:forItem:]): (-[WKUSDPreviewView web_countStringMatches:options:maxCount:]): (-[WKUSDPreviewView web_findString:options:maxCount:]): * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.h: * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (WebKit::WebDataListSuggestionsDropdownIOS::show): * Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm: (-[WKDateTimePicker initWithView:inputType:]): (-[WKDateTimePicker datePickerPopoverControllerDidReset:]): (-[WKDateTimePicker handleDatePickerPresentationDismissal]): (-[WKDateTimePicker removeDatePickerPresentation]): (-[WKDateTimePicker showDateTimePicker]): (-[WKDateTimePicker shouldForceGregorianCalendar]): (-[WKDateTimePicker _sanitizeInputValueForFormatter:]): (-[WKDateTimePicker dateFormatterForPicker]): (-[WKDateTimePicker _dateChanged]): (-[WKDateTimePicker setDateTimePickerToInitialValue]): (-[WKDateTimePicker controlBeginEditing]): (-[WKDateTimePicker controlEndEditing]): * Source/WebKit/UIProcess/ios/forms/WKFormPeripheralBase.mm: (-[WKFormPeripheralBase view]): * Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm: (-[WKSelectTableViewController initWithView:hasGroups:]): (-[WKSelectTableViewController tableView:numberOfRowsInSection:]): (-[WKSelectTableViewController tableView:titleForHeaderInSection:]): (-[WKSelectTableViewController findItemIndexAt:]): (-[WKSelectTableViewController findItemAt:]): (-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]): (-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]): (-[WKSelectTableViewController shouldDismissWithAnimation]): (-[WKSelectTableViewController popover]): (-[WKSelectTableViewController setPopover:]): Canonical link: https://commits.webkit.org/306807@main
25b26da to
9ca92cf
Compare
Collaborator
|
Committed 306807@main (9ca92cf): https://commits.webkit.org/306807@main Reviewed commits have been landed. Closing PR #57843 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
9ca92cf
25b26da