Skip to content

-internal-auto-base() should also work with appearance: base-select#57921

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nt1m:eng/internal-auto-base-should-also-work-with-appearance-base-select
Feb 5, 2026
Merged

-internal-auto-base() should also work with appearance: base-select#57921
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nt1m:eng/internal-auto-base-should-also-work-with-appearance-base-select

Conversation

@nt1m
Copy link
Member

@nt1m nt1m commented Feb 5, 2026 •
edited by webkit-early-warning-system
Loading

de842fb

`-internal-auto-base()` should also work with `appearance: base-select`
https://bugs.webkit.org/show_bug.cgi?id=307024
rdar://169675532

Reviewed by Dan Glastonbury.

We can't use `usedAppearance` here because it's not set yet at this stage.

Check against both `appearance: base` & `appearance: base-select`.

* LayoutTests/fast/forms/appearance-base/internal-auto-base-function-expected.html: Added.
* LayoutTests/fast/forms/appearance-base/internal-auto-base-function.html: Added.
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveInternalAutoBaseFunction):

Canonical link: https://commits.webkit.org/306836@main

15466c2

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
  🛠 tv-sim ✅ 🛠 mac-safer-cpp
  🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m self-assigned this Feb 5, 2026
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Feb 5, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 5, 2026 •
edited
Loading

EWS run on previous version of this PR (hash c5394df)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 wpe-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
  🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2
  🛠 tv-sim ✅ 🛠 mac-safer-cpp
  🛠 watch
  🛠 watch-sim

@nt1m nt1m requested review from anttijk, fantasai and shallawa February 5, 2026 04:17
@nt1m nt1m force-pushed the eng/internal-auto-base-should-also-work-with-appearance-base-select branch from c5394df to 4c715d8 Compare February 5, 2026 04:24
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 5, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 4c715d8)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 wpe-libwebrtc
  🧪 api-ios   🧪 mac-wk1   🛠 gtk
  🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2
  🛠 tv-sim ✅ 🛠 mac-safer-cpp
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/internal-auto-base-should-also-work-with-appearance-base-select branch from 4c715d8 to 31650c3 Compare February 5, 2026 04:26
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 5, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 31650c3)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 win loading 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
⏳ 🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
⏳ 🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
  🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2
  🛠 tv-sim ✅ 🛠 mac-safer-cpp
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/internal-auto-base-should-also-work-with-appearance-base-select branch from 31650c3 to b799c35 Compare February 5, 2026 05:07
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 5, 2026 •
edited
Loading

EWS run on previous version of this PR (hash b799c35)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
  🛠 vision   🧪 mac-wk2 ⏳ 🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2
  🛠 tv-sim   🛠 mac-safer-cpp
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/internal-auto-base-should-also-work-with-appearance-base-select branch from b799c35 to 15466c2 Compare February 5, 2026 05:12
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 5, 2026 •
edited
Loading

EWS run on current version of this PR (hash 15466c2)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 wpe-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
  🛠 tv-sim ✅ 🛠 mac-safer-cpp
  🛠 watch
✅ 🛠 watch-sim

djg
djg approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Feb 5, 2026
@nt1m
-internal-auto-base() should also work with appearance: base-select
de842fb 
https://bugs.webkit.org/show_bug.cgi?id=307024
rdar://169675532

Reviewed by Dan Glastonbury.

We can't use `usedAppearance` here because it's not set yet at this stage.

Check against both `appearance: base` & `appearance: base-select`.

* LayoutTests/fast/forms/appearance-base/internal-auto-base-function-expected.html: Added.
* LayoutTests/fast/forms/appearance-base/internal-auto-base-function.html: Added.
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveInternalAutoBaseFunction):

Canonical link: https://commits.webkit.org/306836@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/internal-auto-base-should-also-work-with-appearance-base-select branch from 15466c2 to de842fb Compare February 5, 2026 07:22
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Feb 5, 2026

Committed 306836@main (de842fb): https://commits.webkit.org/306836@main

Reviewed commits have been landed. Closing PR #57921 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit de842fb into WebKit:main Feb 5, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 5, 2026
@nt1m nt1m deleted the eng/internal-auto-base-should-also-work-with-appearance-base-select branch February 5, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djg djg djg approved these changes

@anttijk anttijk Awaiting requested review from anttijk

@shallawa shallawa Awaiting requested review from shallawa

@fantasai fantasai Awaiting requested review from fantasai

Assignees

@nt1m nt1m

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @djg