Add [WKHTTPCookieStore getCookiesForURL:] API#57975
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 10, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash a4c0dc4) Details |
a4c0dc4 to
7522bd5
Compare
Collaborator
|
EWS run on previous version of this PR (hash 7522bd5) Details
|
rr-codes
reviewed
Feb 10, 2026
Contributor
There was a problem hiding this comment.
Suggested change
| - (void)getCookiesForURL:(NSURL *)url completionHandler:(NS_SWIFT_UI_ACTOR void (^)(NSArray<NSHTTPCookie *> *))completionHandler NS_SWIFT_NAME(getCookies(for:completionHandler:)) WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA), visionos(WK_XROS_TBA)); |
(no need for the WK_ version, especially in public API)
Contributor
There was a problem hiding this comment.
sorry idk why the diff didn’t work but I mean WK_SWIFT_UI_ACTOR -> NS_SWIFT_UI_ACTOR
Contributor
|
you can also add a test to |
rr-codes
approved these changes
Feb 10, 2026
7522bd5 to
a71d7a7
Compare
Collaborator
|
EWS run on current version of this PR (hash a71d7a7) Details
|
rdar://169719343 https://bugs.webkit.org/show_bug.cgi?id=307080 Reviewed by Richard Robinson. [WKHTTPCookieStore _getCookiesForURL:] is proven SPI and many other clients could make great use of it. Tests: Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm * Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.h: * Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm: (-[WKHTTPCookieStore getCookiesForURL:completionHandler:]): (-[WKHTTPCookieStore _getCookiesForURL:completionHandler:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: (TEST(InAppBrowserPrivacy, GetCookieForURLFails)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: (TEST(WKHTTPCookieStore, CookiesForURL)): Canonical link: https://commits.webkit.org/307189@main
a71d7a7 to
7475a7e
Compare
Collaborator
|
Committed 307189@main (7475a7e): https://commits.webkit.org/307189@main Reviewed commits have been landed. Closing PR #57975 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 mac-apple
7475a7e
a71d7a7