[LBSE] Fix svg/custom/focus-ring.svg#58396
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 13, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash fba1a7c) Details |
fba1a7c to
bab84a8
Compare
Collaborator
|
EWS run on previous version of this PR (hash bab84a8) Details |
nikolaszimmermann
approved these changes
Feb 13, 2026
bab84a8 to
e1ede02
Compare
Collaborator
|
EWS run on current version of this PR (hash e1ede02) Details |
https://bugs.webkit.org/show_bug.cgi?id=307537 Reviewed by Nikolas Zimmermann. Fix focus ring by ignoring additionalOffset when the container itself is not transformed since repaintRectInLocalCoordinates position will take any transforms of the children into account, unlike using additionalOffset as position. The remaining fix is avoiding clipping when painting the focus ring in the text and image cases. * LayoutTests/platform/mac-tahoe-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-tahoe-wk2-pixel/svg/custom/focus-ring-expected.png: * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addFocusRingRects const): * Source/WebCore/rendering/svg/RenderSVGContainer.h: * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Canonical link: https://commits.webkit.org/307467@main
e1ede02 to
db29dcc
Compare
Collaborator
|
Committed 307467@main (db29dcc): https://commits.webkit.org/307467@main Reviewed commits have been landed. Closing PR #58396 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db29dcc
e1ede02
🛠 win🧪 win-tests🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios🛠 vision🧪 gtk-wk2🧪 mac-AS-debug-wk2🛠 playstation🛠 mac-safer-cpp🛠 watch