Skip to content

[GFC][Integration] Allow grid items with automatic minimum sizes#58667

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
sammygill:eng/GFC-Integration-Allow-grid-items-with-automatic-minimum-sizes
Feb 14, 2026
Merged

[GFC][Integration] Allow grid items with automatic minimum sizes#58667
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
sammygill:eng/GFC-Integration-Allow-grid-items-with-automatic-minimum-sizes

Conversation

@sammygill
Copy link
Contributor

@sammygill sammygill commented Feb 13, 2026

bc38728

[GFC][Integration] Allow grid items with automatic minimum sizes
https://bugs.webkit.org/show_bug.cgi?id=307848
rdar://170344559

Reviewed by Alan Baradlay.

We have an implementation to determine the automatic minimum size of a
grid item in the inline and block dimensions. These functions are now
being called properly during track and grid item sizing so we should be
able to allow such content in GFC.

* Source/WebCore/layout/formattingContexts/grid/GridLayoutUtils.cpp:
(WebCore::Layout::GridLayoutUtils::hasScrollableInlineOverflow):
(WebCore::Layout::GridLayoutUtils::hasScrollableBlockOverflow):
These are being unconditionally called in the minimum size functions so
change the ASSERT_NOT_IMPLEMENTED_YET() to just notImplemented() and use
the former at the call site instead if somehow this ends up returning
true in the future.

Canonical link: https://commits.webkit.org/307530@main

05cdd73

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
🧪 ios-wk2-wpt 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@sammygill sammygill self-assigned this Feb 13, 2026
@sammygill sammygill added the Layout and Rendering For bugs with layout and rendering of Web pages. label Feb 13, 2026
@sammygill sammygill force-pushed the eng/GFC-Integration-Allow-grid-items-with-automatic-minimum-sizes branch from f659a83 to 05cdd73 Compare February 13, 2026 21:55
@sammygill sammygill added the merge-queue Applied to send a pull request to merge-queue label Feb 13, 2026
https://bugs.webkit.org/show_bug.cgi?id=307848
rdar://170344559

Reviewed by Alan Baradlay.

We have an implementation to determine the automatic minimum size of a
grid item in the inline and block dimensions. These functions are now
being called properly during track and grid item sizing so we should be
able to allow such content in GFC.

* Source/WebCore/layout/formattingContexts/grid/GridLayoutUtils.cpp:
(WebCore::Layout::GridLayoutUtils::hasScrollableInlineOverflow):
(WebCore::Layout::GridLayoutUtils::hasScrollableBlockOverflow):
These are being unconditionally called in the minimum size functions so
change the ASSERT_NOT_IMPLEMENTED_YET() to just notImplemented() and use
the former at the call site instead if somehow this ends up returning
true in the future.

Canonical link: https://commits.webkit.org/307530@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GFC-Integration-Allow-grid-items-with-automatic-minimum-sizes branch from 05cdd73 to bc38728 Compare February 14, 2026 00:06
@webkit-commit-queue
Copy link
Collaborator

Committed 307530@main (bc38728): https://commits.webkit.org/307530@main

Reviewed commits have been landed. Closing PR #58667 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bc38728 into WebKit:main Feb 14, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants