[GFC][Integration] Allow grid items with automatic minimum sizes#58667
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 14, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash f659a83) Details
|
f659a83 to
05cdd73
Compare
Collaborator
|
EWS run on current version of this PR (hash 05cdd73) Details |
alanbaradlay
approved these changes
Feb 13, 2026
https://bugs.webkit.org/show_bug.cgi?id=307848 rdar://170344559 Reviewed by Alan Baradlay. We have an implementation to determine the automatic minimum size of a grid item in the inline and block dimensions. These functions are now being called properly during track and grid item sizing so we should be able to allow such content in GFC. * Source/WebCore/layout/formattingContexts/grid/GridLayoutUtils.cpp: (WebCore::Layout::GridLayoutUtils::hasScrollableInlineOverflow): (WebCore::Layout::GridLayoutUtils::hasScrollableBlockOverflow): These are being unconditionally called in the minimum size functions so change the ASSERT_NOT_IMPLEMENTED_YET() to just notImplemented() and use the former at the call site instead if somehow this ends up returning true in the future. Canonical link: https://commits.webkit.org/307530@main
05cdd73 to
bc38728
Compare
Collaborator
|
Committed 307530@main (bc38728): https://commits.webkit.org/307530@main Reviewed commits have been landed. Closing PR #58667 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
bc38728
05cdd73
🛠 win🧪 win-tests🧪 ios-wk2-wpt🧪 api-mac-debug🛠 playstation