Enhanced <select>: toggle picker on mousedown#59085
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 20, 2026
Merged
Enhanced <select>: toggle picker on mousedown#59085webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
annevk
added
the
Forms
Collaborator
|
EWS run on previous version of this PR (hash 6c735f9) Details |
nt1m
approved these changes
Feb 20, 2026
annevk
force-pushed
the
eng/Enhanced-select-toggle-picker-on-mousedown
branch
from
6c735f9 to
9e8bdd2
Compare
Collaborator
|
EWS run on current version of this PR (hash 9e8bdd2) Details
|
annevk
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=308296 rdar://170742798 Reviewed by Tim Nguyen. appearance: base-select ::picker(select) appears below a <select> by default and as such clicking the <select> is expected to close it. This also happens for normal <select>s on macOS as a side effect of how the OS picker works. To distinguish a click on the <select>'s "button" from a click anywhere on ::picker(select) some composed tree traversal is necessary unfortunately. We also add some early returns for the different event types for clarity. What appears as a regression in select-events-2.optional.html is actually a progression as before we did not get into a state where it could fail. Both of the failures in that test are due to preventDefault() being called in a microtask which at least in combination with WebKit's test runner does not happen at the right point in time. select-popover-exit-animation.html likewise did not get into a state where it could fail before. Canonical link: https://commits.webkit.org/307925@main
webkit-commit-queue
force-pushed
the
eng/Enhanced-select-toggle-picker-on-mousedown
branch
from
9e8bdd2 to
7b7f263
Compare
Collaborator
|
Committed 307925@main (7b7f263): https://commits.webkit.org/307925@main Reviewed commits have been landed. Closing PR #59085 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7b7f263
9e8bdd2
🛠 mac🛠 wpe🛠 win🛠 ios-sim🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 api-mac-debug🛠 gtk3-libwebrtc🧪 api-ios🧪 mac-wk1🛠 ios-safer-cpp🧪 mac-wk2🧪 gtk-wk2🛠 vision🧪 mac-AS-debug-wk2🧪 api-gtk🛠 vision-sim🧪 mac-wk2-stress🛠 playstation🧪 mac-intel-wk2🛠 tv🛠 mac-safer-cpp🛠 tv-sim🛠 watch