[JSC] The pcrtoaddr offlineasm instruction should be lowered differently to support global labels#59296
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Feb 24, 2026
Conversation
Collaborator
|
EWS run on current version of this PR (hash d37b07f) Details |
Constellation
approved these changes
Feb 24, 2026
…tly to support global labels rdar://170991136 https://bugs.webkit.org/show_bug.cgi?id=308517 Reviewed by Yusuke Suzuki. The `pcrtoaddr` instruction is lowered for arm64 into a single `adr` instruction. This works reliably for local labels. JSPI implementation adds a case where the instruction is used to load an address of a global label. In this situation, `adr` appears to work only in some build configurations and in others causes an "unknown fixup kind" build error. This patch augments `pcrtoaddr` implementation so that for global labels it translates into an `adrp`/`add` instruction sequence. For local labels it keeps the existing single-instruction scheme. It also adds a useful externOrGlobal? predicate to LabelReference, used elsewhere for a similar conditional. Testing: integration-tested at its call sites. Canonical link: https://commits.webkit.org/308139@main
d37b07f to
586f364
Compare
Collaborator
|
Committed 308139@main (586f364): https://commits.webkit.org/308139@main Reviewed commits have been landed. Closing PR #59296 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
586f364
d37b07f