Invalid render pass usage leads to crashes in the WebGPU Swift backend

[rr-codes]

ff519ea

Invalid render pass usage leads to crashes in the WebGPU Swift backend
https://bugs.webkit.org/show_bug.cgi?id=308471
rdar://170997914

Reviewed by Mike Wyrzykowski, Lily Spiniolas, and Abrar Rahman Protyasha.

Check that metalDepthStencilTexture is non-nil and has a sampleCount greater than 0 instead of
assuming it is non-nil and force unwrapping it. This matches the non-Swift implementation logic.

Also fix a swift-format formatting error in `USDModel.swift`.

* Source/WebGPU/WebGPU/CommandEncoder.swift:
(WebGPU.beginRenderPass(_:)):
* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:

Canonical link: https://commits.webkit.org/308434@main

744164d

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios		✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 6df40a1)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	🛠 win	⏳ 🛠 ios-apple
	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	🧪 win-tests	⏳ 🛠 mac-apple
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe		⏳ 🛠 vision-apple
	❌ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	❌ 🛠 gtk3-libwebrtc
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	❌ 🛠 gtk
	❌ 🛠 ios-safer-cpp	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	🛠 playstation
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	❌ 🛠 tv	❌ 🛠 mac-safer-cpp
	❌ 🛠 tv-sim
	🛠 watch
	❌ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 744164d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	❌ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios		✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[lilyspiniolas]

Is this testable?

[mwyrzykowski]

Is this testable?

It should be covered by LayoutTests/fast/webgpu/nocrash/fuzz-283006.html but it's not clear to me that WebGPU Swift is running in EWS yet due to compiler requirements.

[mwyrzykowski]

Thank you for fixing! :) This matches the objective-C++ backend now:

            mtlDescriptor.defaultRasterSampleCount = metalDepthStencilTexture.sampleCount;
            if (!mtlDescriptor.defaultRasterSampleCount)
                return RenderPassEncoder::createInvalid(*this, m_device, @"no color targets and depth-stencil texture is nil");
            mtlDescriptor.renderTargetWidth = metalDepthStencilTexture.width;
            mtlDescriptor.renderTargetHeight = metalDepthStencilTexture.height;

[webkit-commit-queue]

Committed 308434@main (ff519ea): https://commits.webkit.org/308434@main

Reviewed commits have been landed. Closing PR #59661 and removing active labels.