Address post-308796@main feedback to remove redundant call#60100
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 9, 2026
Conversation
Collaborator
|
EWS run on current version of this PR (hash 8901fbb) Details |
Contributor
Author
|
@jyavenard - Thanks for your feedback, I did this PR to remove redundant call. |
jyavenard
approved these changes
Mar 9, 2026
https://bugs.webkit.org/show_bug.cgi?id=309390 rdar://171934786 Reviewed by Jean-Yves Avenard. Thanks to Jean-Yves Avenard for flagging that we don't need to create player to set setReadyState() and it is redundant and test passes without this as well. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::textTrackModeChanged): Canonical link: https://commits.webkit.org/308931@main
8901fbb to
1859220
Compare
Collaborator
|
Committed 308931@main (1859220): https://commits.webkit.org/308931@main Reviewed commits have been landed. Closing PR #60100 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1859220
8901fbb