Skip to content

Address post-308796@main feedback to remove redundant call#60100

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Ahmad-S792:eng/Address-post-308796-main-feedback-to-remove-redundant-call
Mar 9, 2026
Merged

Address post-308796@main feedback to remove redundant call#60100
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Ahmad-S792:eng/Address-post-308796-main-feedback-to-remove-redundant-call

Conversation

@Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Mar 6, 2026

@Ahmad-S792 Ahmad-S792 requested review from cdumez and rniwa as code owners March 6, 2026 23:31
@Ahmad-S792 Ahmad-S792 self-assigned this Mar 6, 2026
@Ahmad-S792 Ahmad-S792 added the Media Bugs related to the HTML 5 Media elements. label Mar 6, 2026
@Ahmad-S792 Ahmad-S792 requested a review from jyavenard March 7, 2026 00:43
@Ahmad-S792
Copy link
Contributor Author

@jyavenard - Thanks for your feedback, I did this PR to remove redundant call.

@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2026
https://bugs.webkit.org/show_bug.cgi?id=309390
rdar://171934786

Reviewed by Jean-Yves Avenard.

Thanks to Jean-Yves Avenard for flagging that we don't need to create
player to set setReadyState() and it is redundant and test passes without
this as well.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged):

Canonical link: https://commits.webkit.org/308931@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Address-post-308796-main-feedback-to-remove-redundant-call branch from 8901fbb to 1859220 Compare March 9, 2026 19:59
@webkit-commit-queue
Copy link
Collaborator

Committed 308931@main (1859220): https://commits.webkit.org/308931@main

Reviewed commits have been landed. Closing PR #60100 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1859220 into WebKit:main Mar 9, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants