[List Marker] Collapse anonymous blocks for outside marker when blockification prevents line-box parenting by yulunwu2 · Pull Request #60215 · WebKit/WebKit

yulunwu2 · 2026-03-09T22:04:57Z

`376d3ef`

[List Marker] Collapse anonymous blocks for outside marker when blockification prevents line-box parenting
https://bugs.webkit.org/show_bug.cgi?id=309925
<rdar://165933903>

Reviewed by Alan Baradlay.

findParentOfEmptyOrFirstLineBox sometimes fails to find a suitable line-box
parent when a list item contains a flex or grid container because flex/grid
containers blockify inline content like <svg> and <img>. In this case, we
fall back to creating an anonymous block to parent the list marker. However,
this causes layout issues because the anonymous block's inherited line height
pushes the visible content down (and no longer next to the list marker).

This fixes the issue by detecting parenting failure due to blockification
and flagging the marker to collapse its parent block.

* LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block-expected.html: Added.
* LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp:
(WebCore::Layout::InlineQuirks::shouldCollapseLineBoxHeight const):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp:
(WebCore::LayoutIntegration::updateListMarkerAttributes):
(WebCore::LayoutIntegration::BoxTreeUpdater::createLayoutBox):
* Source/WebCore/layout/layouttree/LayoutElementBox.h:
(WebCore::Layout::ElementBox::shouldCollapseAnonymousBlockParentForListMarker const):
* Source/WebCore/rendering/RenderListMarker.h:
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
(WebCore::findParentOfEmptyOrFirstLineBox):
(WebCore::parentCandidateForMarker):
(WebCore::RenderTreeBuilder::List::updateItemMarker):

Canonical link: https://commits.webkit.org/309272@main

53a8ef8

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-03-09T22:05:05Z

EWS run on previous version of this PR (hash 73b7091)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/rendering/RenderBlockFlow.cpp

Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

Source/WebCore/rendering/RenderListMarker.h

LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block.html

webkit-early-warning-system · 2026-03-11T03:07:22Z

EWS run on previous version of this PR (hash a0907e7)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	❌ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2026-03-11T07:13:54Z

macOS Safer C++ Build #85184 (`a0907e7`)

❌ Found 1 failing file with 2 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-ews-buildbot · 2026-03-11T07:15:56Z

iOS Safer C++ Build #3416 (`a0907e7`)

❌ Found 1 failing file with 2 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

Source/WebCore/rendering/RenderListMarker.h

alanbaradlay · 2026-03-11T14:31:15Z

Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp

+    if (rootBox.isAnonymous() && lineContent[0].isListMarkerOutside()) {
+        // When an outside marker ends up in an anonymous block because blockification (e.g., by a flex/grid container)
+        // prevented finding a line box parent, collapse the line box so it doesn't inflate the list item.
+        auto* markerRenderer = dynamicDowncast<RenderListMarker>(lineContent[0].layoutBox().rendererForIntegration());


We try not to access renderers from inside IFC -well except the integration layer- but transfer such states from renderers to layout boxes while building the tree. ElementBox already has examples like this see setListMarkerLayoutBounds. I would also fold this logic under if (lineContent[0].isListMarkerOutside()... -few lines above.

Done, thanks for the review!

Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

webkit-early-warning-system · 2026-03-11T21:59:13Z

EWS run on previous version of this PR (hash e352452)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp

Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

webkit-early-warning-system · 2026-03-13T04:36:53Z

EWS run on previous version of this PR (hash b3d1801)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	~~🛠 ios-safer-cpp~~	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-03-13T19:54:45Z

EWS run on previous version of this PR (hash 03e0dd4)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~	🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe		🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	~~🧪 mac-wk1~~	✅ 🛠 gtk
	~~🛠 ios-safer-cpp~~	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	~~🛠 vision-sim~~	✅ 🧪 mac-wk2-stress	~~🛠 playstation~~
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	~~🛠 tv-sim~~
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-03-13T23:18:00Z

EWS run on previous version of this PR (hash bb98bd6)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~	🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~		🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	~~🛠 gtk3-libwebrtc~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🛠 gtk~~
	~~🛠 ios-safer-cpp~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🛠 playstation~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2026-03-13T23:35:45Z

EWS run on previous version of this PR (hash 43b891e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~	⏳ 🛠 ios-apple
✅ 🧪 bindings	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~		⏳ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	~~🛠 gtk3-libwebrtc~~
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	~~🛠 gtk~~
	~~🛠 ios-safer-cpp~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🛠 playstation~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2026-03-13T23:38:33Z

EWS run on previous version of this PR (hash f0bebfa)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	~~🛠 ios-safer-cpp~~	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

alanbaradlay · 2026-03-14T01:07:51Z

Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp

-    if (!lineContent[0].isListMarkerOutside()) {
-        ASSERT(lineContent[0].isListMarkerInside());
+    auto& marker = lineContent[0];
+    auto* markerBox = dynamicDowncast<Layout::ElementBox>(lineContent[0].layoutBox());


marker.layoutBox()

Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

webkit-early-warning-system · 2026-03-14T06:49:20Z

EWS run on current version of this PR (hash 53a8ef8)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🛠 ios-safer-cpp	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2026-03-14T16:16:39Z

Safe-Merge-Queue: Build #86611.

…ification prevents line-box parenting https://bugs.webkit.org/show_bug.cgi?id=309925 <rdar://165933903> Reviewed by Alan Baradlay. findParentOfEmptyOrFirstLineBox sometimes fails to find a suitable line-box parent when a list item contains a flex or grid container because flex/grid containers blockify inline content like <svg> and <img>. In this case, we fall back to creating an anonymous block to parent the list marker. However, this causes layout issues because the anonymous block's inherited line height pushes the visible content down (and no longer next to the list marker). This fixes the issue by detecting parenting failure due to blockification and flagging the marker to collapse its parent block. * LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block-expected.html: Added. * LayoutTests/fast/lists/list-marker-outside-flex-collapse-anonymous-block.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp: (WebCore::Layout::InlineQuirks::shouldCollapseLineBoxHeight const): * Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp: (WebCore::LayoutIntegration::updateListMarkerAttributes): (WebCore::LayoutIntegration::BoxTreeUpdater::createLayoutBox): * Source/WebCore/layout/layouttree/LayoutElementBox.h: (WebCore::Layout::ElementBox::shouldCollapseAnonymousBlockParentForListMarker const): * Source/WebCore/rendering/RenderListMarker.h: * Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp: (WebCore::findParentOfEmptyOrFirstLineBox): (WebCore::parentCandidateForMarker): (WebCore::RenderTreeBuilder::List::updateItemMarker): Canonical link: https://commits.webkit.org/309272@main

webkit-commit-queue · 2026-03-14T16:36:11Z

Committed 309272@main (376d3ef): https://commits.webkit.org/309272@main

Reviewed commits have been landed. Closing PR #60215 and removing active labels.

yulunwu2 self-assigned this Mar 9, 2026

yulunwu2 added the Layout and Rendering For bugs with layout and rendering of Web pages. label Mar 9, 2026

yulunwu2 requested a review from alanbaradlay March 9, 2026 22:05

alanbaradlay reviewed Mar 9, 2026

View reviewed changes

yulunwu2 force-pushed the radar_165933903 branch from 73b7091 to a0907e7 Compare March 11, 2026 03:07

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 11, 2026

alanbaradlay reviewed Mar 11, 2026

View reviewed changes

yulunwu2 removed the merging-blocked Applied to prevent a change from being merged label Mar 11, 2026

yulunwu2 force-pushed the radar_165933903 branch from a0907e7 to e352452 Compare March 11, 2026 21:59

yulunwu2 requested a review from alanbaradlay March 11, 2026 22:00

alanbaradlay reviewed Mar 12, 2026

View reviewed changes

yulunwu2 changed the title ~~[List Marker] Collapse anonymous block height for outside marker when blockification prevents line-box parenting~~ [List Marker] Collapse anonymous block height for outside marker when a block child prevents line-box parenting Mar 13, 2026

yulunwu2 force-pushed the radar_165933903 branch from e352452 to b3d1801 Compare March 13, 2026 04:36

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 13, 2026

yulunwu2 removed the merging-blocked Applied to prevent a change from being merged label Mar 13, 2026

yulunwu2 changed the title ~~[List Marker] Collapse anonymous block height for outside marker when a block child prevents line-box parenting~~ [List Marker] Collapse anonymous block height for outside marker when blockification prevents line-box parenting Mar 13, 2026

yulunwu2 force-pushed the radar_165933903 branch from b3d1801 to 03e0dd4 Compare March 13, 2026 19:54

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 13, 2026

yulunwu2 removed the merging-blocked Applied to prevent a change from being merged label Mar 13, 2026

yulunwu2 force-pushed the radar_165933903 branch from 03e0dd4 to bb98bd6 Compare March 13, 2026 23:17

yulunwu2 force-pushed the radar_165933903 branch from bb98bd6 to 43b891e Compare March 13, 2026 23:35

yulunwu2 changed the title ~~[List Marker] Collapse anonymous block height for outside marker when blockification prevents line-box parenting~~ [List Marker] Collapse anonymous blocks for outside marker when blockification prevents line-box parenting Mar 13, 2026

yulunwu2 force-pushed the radar_165933903 branch from 43b891e to f0bebfa Compare March 13, 2026 23:38

yulunwu2 requested a review from alanbaradlay March 13, 2026 23:38

alanbaradlay approved these changes Mar 14, 2026

View reviewed changes

yulunwu2 force-pushed the radar_165933903 branch from f0bebfa to 53a8ef8 Compare March 14, 2026 06:49

yulunwu2 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 14, 2026

webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 14, 2026

webkit-commit-queue force-pushed the radar_165933903 branch from 53a8ef8 to 376d3ef Compare March 14, 2026 16:36

webkit-commit-queue merged commit 376d3ef into WebKit:main Mar 14, 2026

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 14, 2026

Conversation

yulunwu2 commented Mar 9, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

376d3ef

Uh oh!

webkit-early-warning-system commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Mar 11, 2026

macOS Safer C++ Build #85184 (a0907e7)

Uh oh!

webkit-ews-buildbot commented Mar 11, 2026

iOS Safer C++ Build #3416 (a0907e7)

Uh oh!

Uh oh!

alanbaradlay Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

yulunwu2 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alanbaradlay Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Mar 14, 2026

Uh oh!

webkit-commit-queue commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yulunwu2 commented Mar 9, 2026 •

edited by webkit-early-warning-system

Loading

`376d3ef`

webkit-early-warning-system commented Mar 9, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 11, 2026 •

edited

Loading

macOS Safer C++ Build #85184 (`a0907e7`)

iOS Safer C++ Build #3416 (`a0907e7`)

webkit-early-warning-system commented Mar 11, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 13, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 13, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 13, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 13, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 13, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 14, 2026 •

edited

Loading