[ iOS Release ] http/tests/misc/embed-image-load-outlives-gc-without-crashing.html is a flakey timeout#60258
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 10, 2026
Conversation
Collaborator
|
EWS run on current version of this PR (hash 327ea4e) Details
|
🛠 mac-apple
cdumez
approved these changes
Mar 10, 2026
Contributor
cdumez
left a comment
cdumez
left a comment
There was a problem hiding this comment.
I guess it's worth trying though I'm surprised we're not unskipping the test here.
rniwa
added
the
unsafe-merge-queue
…crashing.html is a flakey timeout https://bugs.webkit.org/show_bug.cgi?id=295989 rdar://155885979 Reviewed by Chris Dumez. Based on Claude's analysis, this test flakiness comes from requestAnimationFrame sometimes not firing in iOS. On iOS, requestAnimationFrame callbacks only fire when the compositor schedules a rendering update, which may or may not happen after a call to requestAnimationFrame in the test. Try replacing requestAnimationFrame with setTimeout to make it more reliable. * LayoutTests/http/tests/misc/embed-image-load-outlives-gc-without-crashing.html: Canonical link: https://commits.webkit.org/308977@main
webkit-commit-queue
force-pushed
the
fix295989-embed-image-load-outlives-gc-without-crashing-ios-flakiness
branch
from
327ea4e to
bd9598e
Compare
Collaborator
|
Committed 308977@main (bd9598e): https://commits.webkit.org/308977@main Reviewed commits have been landed. Closing PR #60258 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
rniwa
deleted the
fix295989-embed-image-load-outlives-gc-without-crashing-ios-flakiness
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bd9598e
327ea4e
🛠 win🧪 win-tests