[AutoFill Debugging] Prefer case-sensitive matches before falling back to case-insensitive search#60367
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 11, 2026
Merged
Conversation
whsieh
added
the
New Bugs
Collaborator
|
EWS run on previous version of this PR (hash 0a28a57) Details
|
whsieh
requested review from
aprotyas,
hortont424,
lilyspiniolas,
megangardner,
pascoej,
pxlcoder and
rr-codes
pxlcoder
approved these changes
Mar 11, 2026
| @@ -571,9 +571,11 @@ - (void)receiveDictionaryFromWebProcess:(NSDictionary *)dictionary | |||
| }()]; | |||
|
|
|||
| NSArray<NSString *> *lines = [debugText componentsSeparatedByString:@"\n"]; | |||
| EXPECT_EQ([lines count], 2u); | |||
| NSLog(@"<WK>: %@", lines); | |||
Member
Author
There was a problem hiding this comment.
🤦 Whoops, removed.
Thanks for the review!
Collaborator
|
EWS run on current version of this PR (hash 487c75b) Details
|
…k to case-insensitive search https://bugs.webkit.org/show_bug.cgi?id=309680 rdar://172283407 Reviewed by Aditya Keerthi. Adjust `TextExtraction::searchForText`, such that it prefers exact, case-sensitive text matches in the DOM before falling back to a case-insensitive search. Tests: TextExtractionTests.RequestJSHandleForNodeIdentifierCaseSensitive * Source/WebCore/page/text-extraction/TextExtraction.cpp: (WebCore::TextExtraction::searchForText): * Tools/TestWebKitAPI/Tests/WebKitCocoa/TextExtractionTests.mm: (TestWebKitAPI::TEST(TextExtractionTests, RequestJSHandleForNodeIdentifierCaseSensitive)): * Tools/TestWebKitAPI/Tests/WebKitCocoa/debug-text-extraction.html: Canonical link: https://commits.webkit.org/309074@main
webkit-commit-queue
force-pushed
the
eng/309680
branch
from
487c75b to
37b7ce7
Compare
Collaborator
|
Committed 309074@main (37b7ce7): https://commits.webkit.org/309074@main Reviewed commits have been landed. Closing PR #60367 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
37b7ce7
487c75b
🛠 win🧪 win-tests🧪 ios-wk2-wpt🧪 api-mac-debug🛠 ios-safer-cpp🧪 vision-wk2