-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Remove insecure Crypto algorithms from WebCrypto #6040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
EWS run on previous version of this PR (hash d171fef)
|
d171fef to
d5fa7a5
Compare
|
EWS run on previous version of this PR (hash d5fa7a5)
|
|
Have other browser engines removed this algorithm? |
Firefox and Chrome don't support it, don't know if they did it previously. Just following the security guidelines |
d5fa7a5 to
293d79c
Compare
|
EWS run on previous version of this PR (hash 293d79c)
|
293d79c to
0c0c0b8
Compare
|
EWS run on previous version of this PR (hash 0c0c0b8)
|
0c0c0b8 to
74927cc
Compare
|
EWS run on previous version of this PR (hash 74927cc)
|
74927cc to
9a7725b
Compare
|
EWS run on previous version of this PR (hash 9a7725b)
|
|
This has been breaking the WinCairo EWS, not entirely sure why it's not recovering nicely. But the CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp file seems to be referenced in Source/WebCore/platform/OpenSSL.cmake and presumably needs to be removed from there. |
8a2d9a3 to
d22cc27
Compare
|
EWS run on previous version of this PR (hash 8a2d9a3)
|
d22cc27 to
f74d84e
Compare
Ok thank you |
|
EWS run on previous version of this PR (hash d22cc27)
|
|
EWS run on previous version of this PR (hash f74d84e)
|
8870356 to
293d79c
Compare
|
EWS run on previous version of this PR (hash 141ac28)
|
|
EWS run on previous version of this PR (hash 4fea648)
|
17dcb00 to
16c6389
Compare
|
EWS run on previous version of this PR (hash 16c6389)
|
|
EWS run on previous version of this PR (hash 716dbdf) |
716dbdf to
394199b
Compare
|
EWS run on previous version of this PR (hash 394199b)
|
394199b to
a3deede
Compare
|
EWS run on previous version of this PR (hash a3deede)
|
a3deede to
93a2823
Compare
|
EWS run on previous version of this PR (hash 93a2823)
|
93a2823 to
7173c97
Compare
|
EWS run on previous version of this PR (hash 7173c97)
|
7173c97 to
2ad81a6
Compare
|
EWS run on previous version of this PR (hash 2ad81a6)
|
2ad81a6 to
abd29c4
Compare
|
EWS run on previous version of this PR (hash abd29c4)
|
abd29c4 to
35394ed
Compare
|
EWS run on previous version of this PR (hash 35394ed)
|
35394ed to
2e8b545
Compare
|
EWS run on previous version of this PR (hash 2e8b545)
|
2e8b545 to
af4d059
Compare
|
EWS run on previous version of this PR (hash af4d059)
|
af4d059 to
9af3960
Compare
|
EWS run on previous version of this PR (hash 9af3960)
|
https://bugs.webkit.org/show_bug.cgi?id=247358 rdar://101765059 Reviewed by NOBODY (OOPS!). Removing RSAES_v1_5 from the list of algorithms we have. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key.html: Removed. * Source/WebCore/Sources.txt: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::write): (WebCore::CloneDeserializer::read): * Source/WebCore/crypto/CryptoAlgorithmIdentifier.h: * Source/WebCore/crypto/SubtleCrypto.cpp: (WebCore::normalizeCryptoAlgorithmParameters): (WebCore::isSupportedExportKey): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp: Removed. * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/crypto/mac/CryptoAlgorithmAES_CTRMac.cpp: * Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp: Removed. * Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms) * LayoutTests/crypto/subtle/generate-key-malformed-parameters.html: * LayoutTests/crypto/subtle/import-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsa-generate-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsa-import-key-malformed-parameters.html: * LayoutTests/crypto/workers/subtle/rsa-postMessage-worker.html: Removed. * LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Removed. * LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384-expected.txt: * LayoutTests/crypto/subtle/generate-key-malformed-parameters.html: * LayoutTests/crypto/subtle/import-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsa-generate-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsa-import-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages.html: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-expected.txt: Added. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key.html: Added. * LayoutTests/crypto/workers/subtle/rsa-postMessage-worker.html: Added. * LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Added. * LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Added. * Source/WebCore/Sources.txt: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::write): (WebCore::CloneDeserializer::read): * Source/WebCore/crypto/CryptoAlgorithmIdentifier.h: * Source/WebCore/crypto/SubtleCrypto.cpp: (WebCore::normalizeCryptoAlgorithmParameters): (WebCore::isSupportedExportKey): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp: Added. (WebCore::gcryptEncrypt): (WebCore::gcryptDecrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/crypto/mac/CryptoAlgorithmAES_CTRMac.cpp: * Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp: Added. (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt): * Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/platform/OpenSSL.cmake: * Source/WebCore/platform/SourcesGCrypt.txt: * LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384-expected.txt: * LayoutTests/crypto/subtle/generate-key-malformed-parameters.html: * LayoutTests/crypto/subtle/import-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsa-generate-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsa-import-key-malformed-parameters.html: * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages.html: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-expected.txt: Removed. * LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key.html: Removed. * LayoutTests/crypto/workers/subtle/rsa-postMessage-worker.html: Removed. * LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Removed. * LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Removed. * Source/WebCore/Sources.txt: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::write): (WebCore::CloneDeserializer::read): * Source/WebCore/crypto/CryptoAlgorithmIdentifier.h: * Source/WebCore/crypto/SubtleCrypto.cpp: (WebCore::normalizeCryptoAlgorithmParameters): (WebCore::isSupportedExportKey): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp: Removed. * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/crypto/mac/CryptoAlgorithmAES_CTRMac.cpp: * Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp: Removed. * Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp: (WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): * Source/WebCore/platform/OpenSSL.cmake: * Source/WebCore/platform/SourcesGCrypt.txt: * LayoutTests/crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-private-expected.txt: * LayoutTests/crypto/subtle/ecdsa-import-compressed-spki-key-p384-expected.txt: * LayoutTests/crypto/subtle/generate-key-malformed-parameters-expected.txt: * LayoutTests/crypto/subtle/import-key-malformed-parameters-expected.txt: * LayoutTests/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: * LayoutTests/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
9af3960 to
20ce856
Compare
|
EWS run on current version of this PR (hash 20ce856)
|
|
Let's introduce a runtime flag instead of removing the support directly. |
🛠 wincairo
d171fefed730740ee8772c1edf33bc3037e93e90
20ce856