REGRESSION(303293@main): Broke watchOS debug build ('UIContextMenuInteractionDelegate' is unavailable)#60510
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 13, 2026
Merged
Conversation
aprotyas
added
the
New Bugs
Collaborator
|
EWS run on current version of this PR (hash 95a7672) Details
|
pxlcoder
approved these changes
Mar 13, 2026
Member
Author
|
Thank you for the review! |
aprotyas
added
the
unsafe-merge-queue
…eractionDelegate' is unavailable) https://bugs.webkit.org/show_bug.cgi?id=309837 rdar://172417044 Unreviewed build fix. TWKAPI was not building on watchOS because `TestContextMenuDelegate` in CaptionPreferencesTests.mm adhered to UIContextMenuInteractionDelegate, which is not available on watchOS. On a second read, this delegate is not used at all in the test suite, so let's just remove it. * Tools/TestWebKitAPI/Tests/WebCore/cocoa/CaptionPreferencesTests.mm: (-[TestContextMenuDelegate contextMenuInteraction:configurationForMenuAtLocation:]): Deleted. Canonical link: https://commits.webkit.org/309185@main
webkit-commit-queue
force-pushed
the
eng/309837
branch
from
95a7672 to
e03b1b9
Compare
Collaborator
|
Committed 309185@main (e03b1b9): https://commits.webkit.org/309185@main Reviewed commits have been landed. Closing PR #60510 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e03b1b9
REGRESSION(303293@main): Broke watchOS debug build ('UIContextMenuInteractionDelegate' is unavailable) https://bugs.webkit.org/show_bug.cgi?id=309837 rdar://172417044 Unreviewed build fix. TWKAPI was not building on watchOS because `TestContextMenuDelegate` in CaptionPreferencesTests.mm adhered to UIContextMenuInteractionDelegate, which is not available on watchOS. On a second read, this delegate is not used at all in the test suite, so let's just remove it. * Tools/TestWebKitAPI/Tests/WebCore/cocoa/CaptionPreferencesTests.mm: (-[TestContextMenuDelegate contextMenuInteraction:configurationForMenuAtLocation:]): Deleted. Canonical link: https://commits.webkit.org/309185@main95a7672
🧪 win-tests🧪 api-mac-debug