Skip to content

<model> does not support negative playback rates#60531

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mwyrzykowski:eng/model-does-not-support-negative-playback-rates
Mar 13, 2026
Merged

<model> does not support negative playback rates#60531
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mwyrzykowski:eng/model-does-not-support-negative-playback-rates

Conversation

@mwyrzykowski
Copy link
Copy Markdown
Contributor

@mwyrzykowski mwyrzykowski commented Mar 13, 2026 •
edited by webkit-early-warning-system
Loading

971485d

<model> does not support negative playback rates
https://bugs.webkit.org/show_bug.cgi?id=309860
rdar://172433492

Reviewed by Etienne Segonzac.

Adjust math such that negative deltaTime is correctly handled.

* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(USDModelLoader.update(_:)):

Canonical link: https://commits.webkit.org/309226@main

0c8a728

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
  🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski requested a review from rr-codes as a code owner March 13, 2026 02:01
@mwyrzykowski mwyrzykowski self-assigned this Mar 13, 2026
@mwyrzykowski mwyrzykowski added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 13, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Mar 13, 2026 •
edited
Loading

EWS run on current version of this PR (hash 0c8a728)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
  🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

etiennesegonzac
etiennesegonzac approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@etiennesegonzac etiennesegonzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Mar 13, 2026
@mwyrzykowski
<model> does not support negative playback rates
971485d 
https://bugs.webkit.org/show_bug.cgi?id=309860
rdar://172433492

Reviewed by Etienne Segonzac.

Adjust math such that negative deltaTime is correctly handled.

* Source/WebKit/GPUProcess/graphics/Model/USDModel.swift:
(USDModelLoader.update(_:)):

Canonical link: https://commits.webkit.org/309226@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/model-does-not-support-negative-playback-rates branch from 0c8a728 to 971485d Compare March 13, 2026 20:10
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Mar 13, 2026

Committed 309226@main (971485d): https://commits.webkit.org/309226@main

Reviewed commits have been landed. Closing PR #60531 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 971485d into WebKit:main Mar 13, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rr-codes rr-codes rr-codes left review comments

@etiennesegonzac etiennesegonzac etiennesegonzac approved these changes

@amarchenko amarchenko Awaiting requested review from amarchenko

Assignees

@mwyrzykowski mwyrzykowski

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @etiennesegonzac @rr-codes