Skip to content

[macOS Release] inspector/page/setShowPaintRects.html is a flaky text failure#60579

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
diegodelatoba:eng/macOS-Release-inspector-page-setShowPaintRects-html-is-a-flaky-text-failure
Mar 14, 2026
Merged

[macOS Release] inspector/page/setShowPaintRects.html is a flaky text failure#60579
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
diegodelatoba:eng/macOS-Release-inspector-page-setShowPaintRects-html-is-a-flaky-text-failure

Conversation

@diegodelatoba
Copy link
Contributor

@diegodelatoba diegodelatoba commented Mar 13, 2026

9e68a23

[macOS Release] inspector/page/setShowPaintRects.html is a flaky text failure
rdar://172419591
https://bugs.webkit.org/show_bug.cgi?id=309840

Reviewed by BJ Burg.

This test is flakily failing it's second test becauase
Sometimes while dumping results from the first test to the
DOM, setShowPaintRects state is still true and subsequently
paint rects are created that leak into the second test which
expects no paint rects.

The fix here is to explicitly set setShowPaintRects to false
before printing those results to DOM.

* LayoutTests/inspector/page/setShowPaintRects.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/309265@main

57340fc

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@diegodelatoba diegodelatoba self-assigned this Mar 13, 2026
@diegodelatoba diegodelatoba marked this pull request as draft March 13, 2026 22:13
@diegodelatoba diegodelatoba marked this pull request as ready for review March 13, 2026 22:13
@diegodelatoba diegodelatoba force-pushed the eng/macOS-Release-inspector-page-setShowPaintRects-html-is-a-flaky-text-failure branch from c1dff88 to 57340fc Compare March 13, 2026 23:21
@burg burg added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 14, 2026
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 14, 2026
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #86580.

… failure

rdar://172419591
https://bugs.webkit.org/show_bug.cgi?id=309840

Reviewed by BJ Burg.

This test is flakily failing it's second test becauase
Sometimes while dumping results from the first test to the
DOM, setShowPaintRects state is still true and subsequently
paint rects are created that leak into the second test which
expects no paint rects.

The fix here is to explicitly set setShowPaintRects to false
before printing those results to DOM.

* LayoutTests/inspector/page/setShowPaintRects.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/309265@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/macOS-Release-inspector-page-setShowPaintRects-html-is-a-flaky-text-failure branch from 57340fc to 9e68a23 Compare March 14, 2026 08:51
@webkit-commit-queue
Copy link
Collaborator

Committed 309265@main (9e68a23): https://commits.webkit.org/309265@main

Reviewed commits have been landed. Closing PR #60579 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9e68a23 into WebKit:main Mar 14, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants