[macOS Release] inspector/page/setShowPaintRects.html is a flaky text failure#60579
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 14, 2026
Conversation
c1dff88 to
57340fc
Compare
Collaborator
|
EWS run on current version of this PR (hash 57340fc) Details |
burg
approved these changes
Mar 14, 2026
Collaborator
|
Safe-Merge-Queue: Build #86580. |
… failure rdar://172419591 https://bugs.webkit.org/show_bug.cgi?id=309840 Reviewed by BJ Burg. This test is flakily failing it's second test becauase Sometimes while dumping results from the first test to the DOM, setShowPaintRects state is still true and subsequently paint rects are created that leak into the second test which expects no paint rects. The fix here is to explicitly set setShowPaintRects to false before printing those results to DOM. * LayoutTests/inspector/page/setShowPaintRects.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/309265@main
57340fc to
9e68a23
Compare
Collaborator
|
Committed 309265@main (9e68a23): https://commits.webkit.org/309265@main Reviewed commits have been landed. Closing PR #60579 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9e68a23
57340fc
🧪 win-tests