[Swift in WebKit] Work towards integrating Swift Testing into WebKit by rr-codes · Pull Request #60626 · WebKit/WebKit

rr-codes · 2026-03-14T08:40:44Z

`53d30e1`

[Swift in WebKit] Work towards integrating Swift Testing into WebKit
https://bugs.webkit.org/show_bug.cgi?id=309952
rdar://172543926

Reviewed by Abrar Rahman Protyasha.

This is step two of three for fully integrating Swift Testing into WebKit. Now, to run these native tests
locally, all you have to do is press Command+U in Xcode!

* Tools/TestWebKitAPI/Configurations/TestWebKitAPIBundle.xcconfig:
* Tools/TestWebKitAPI/TestBundle/GoogleTests.mm: Removed.

Remove this currently unused, experimental way of running GTests as XCTests, since this is not a goal
at present and gets in the way of being able to run the test plan completely.

* Tools/TestWebKitAPI/TestBundle/TestWebKitAPI.xctestplan:

- Disable code coverage. This is a fairly useless metric for these limited tests, and also substantially
increases how long the tests take to run.
- Disable parallelization, since WebKit is always used on the main thread

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Let Xcode sort some files.

* Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageNavigationTests.swift:
* WebKit.xcworkspace/xcshareddata/xcschemes/Everything up to WebKit + Tools.xcscheme:

Use the test plan for the Test action of the "Everything up to WebKit + Tools" scheme.

* Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageNavigationTests.swift:

Disable a slow test.

Canonical link: https://commits.webkit.org/309343@main

cc5731d

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 gtk3-libwebrtc
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
		✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
~~🛠 🧪 merge~~	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-03-14T08:40:51Z

EWS run on previous version of this PR (hash d3d8527)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	⏳ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	⏳ 🛠 mac-apple
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 gtk3-libwebrtc
	~~🧪 api-ios~~	~~🧪 mac-wk1~~	✅ 🛠 gtk
		~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	~~🛠 tv-sim~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-03-14T08:48:51Z

EWS run on previous version of this PR (hash 82a52d5)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
		✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2026-03-15T06:44:17Z

EWS run on previous version of this PR (hash 25dc86a)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win	✅ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe		✅ 🛠 vision-apple
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🛠 gtk
		✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🛠 playstation
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

aprotyas

LGTM, I wouldn't disable the test unless it's timing out?

aprotyas · 2026-03-16T17:47:36Z

Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageNavigationTests.swift

@@ -155,7 +155,7 @@ struct WebPageNavigationTests {
        }
    }

-    @Test
+    @Test(.disabled("This test is too slow"))


too slow that it times out? We do have other API tests that take multiple seconds

It has a hard-coded delay of 10 seconds, which is unacceptable for CI (and there’s no way to not have a hard coded delay because observing the sequence itself modifies the result lol)

webkit-early-warning-system · 2026-03-16T19:09:53Z

EWS run on current version of this PR (hash cc5731d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows	Apple Internal
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~	❌ 🛠 ios-apple
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~	✅ 🛠 mac-apple
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe		⏳ 🛠 vision-apple
	~~🧪 ios-wk2-wpt~~	~~🧪 api-mac-debug~~	✅ 🛠 gtk3-libwebrtc
	~~🧪 api-ios~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
		✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
~~🛠 🧪 merge~~	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=309952 rdar://172543926 Reviewed by Abrar Rahman Protyasha. This is step two of three for fully integrating Swift Testing into WebKit. Now, to run these native tests locally, all you have to do is press Command+U in Xcode! * Tools/TestWebKitAPI/Configurations/TestWebKitAPIBundle.xcconfig: * Tools/TestWebKitAPI/TestBundle/GoogleTests.mm: Removed. Remove this currently unused, experimental way of running GTests as XCTests, since this is not a goal at present and gets in the way of being able to run the test plan completely. * Tools/TestWebKitAPI/TestBundle/TestWebKitAPI.xctestplan: - Disable code coverage. This is a fairly useless metric for these limited tests, and also substantially increases how long the tests take to run. - Disable parallelization, since WebKit is always used on the main thread * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode sort some files. * Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageNavigationTests.swift: * WebKit.xcworkspace/xcshareddata/xcschemes/Everything up to WebKit + Tools.xcscheme: Use the test plan for the Test action of the "Everything up to WebKit + Tools" scheme. * Tools/TestWebKitAPI/Tests/WebKit Swift/WebPageNavigationTests.swift: Disable a slow test. Canonical link: https://commits.webkit.org/309343@main

webkit-commit-queue · 2026-03-16T19:57:15Z

Committed 309343@main (53d30e1): https://commits.webkit.org/309343@main

Reviewed commits have been landed. Closing PR #60626 and removing active labels.

rr-codes requested a review from emw-apple as a code owner March 14, 2026 08:40

rr-codes self-assigned this Mar 14, 2026

rr-codes added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Mar 14, 2026

rr-codes force-pushed the eng/Swift-in-WebKit-Work-towards-integrating-Swift-Testing-into-WebKit branch from d3d8527 to 82a52d5 Compare March 14, 2026 08:48

rr-codes requested review from aestes, aprotyas, hortont424, lilyspiniolas, megangardner, pascoej, pxlcoder and whsieh March 14, 2026 08:52

rr-codes force-pushed the eng/Swift-in-WebKit-Work-towards-integrating-Swift-Testing-into-WebKit branch from 82a52d5 to 25dc86a Compare March 15, 2026 06:44

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 15, 2026

aprotyas approved these changes Mar 16, 2026

View reviewed changes

rr-codes removed the merging-blocked Applied to prevent a change from being merged label Mar 16, 2026

rr-codes force-pushed the eng/Swift-in-WebKit-Work-towards-integrating-Swift-Testing-into-WebKit branch from 25dc86a to cc5731d Compare March 16, 2026 19:09

rr-codes added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Mar 16, 2026

webkit-commit-queue force-pushed the eng/Swift-in-WebKit-Work-towards-integrating-Swift-Testing-into-WebKit branch from cc5731d to 53d30e1 Compare March 16, 2026 19:57

webkit-commit-queue merged commit 53d30e1 into WebKit:main Mar 16, 2026

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Swift in WebKit] Work towards integrating Swift Testing into WebKit#60626

[Swift in WebKit] Work towards integrating Swift Testing into WebKit#60626
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rr-codes:eng/Swift-in-WebKit-Work-towards-integrating-Swift-Testing-into-WebKit

rr-codes commented Mar 14, 2026 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Mar 14, 2026 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 14, 2026 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 15, 2026 •

edited

Loading

Uh oh!

aprotyas left a comment

Uh oh!

aprotyas Mar 16, 2026

Uh oh!

rr-codes Mar 16, 2026

Uh oh!

webkit-early-warning-system commented Mar 16, 2026 •

edited

Loading

Uh oh!

webkit-commit-queue commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rr-codes commented Mar 14, 2026 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

53d30e1

Uh oh!

webkit-early-warning-system commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aprotyas left a comment

Choose a reason for hiding this comment

Uh oh!

aprotyas Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

rr-codes Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rr-codes commented Mar 14, 2026 •

edited by webkit-early-warning-system

Loading

`53d30e1`

webkit-early-warning-system commented Mar 14, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 14, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 15, 2026 •

edited

Loading

webkit-early-warning-system commented Mar 16, 2026 •

edited

Loading