REGRESSION (308504@main): Multiple fast/text-extraction tests crash on internal macOS test runners#60865
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 18, 2026
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 8546a38) Details
|
aprotyas
approved these changes
Mar 18, 2026
Member
Author
|
Thanks for the review! |
…n internal macOS test runners https://bugs.webkit.org/show_bug.cgi?id=310189 rdar://172823439 Reviewed by Abrar Rahman Protyasha. Make several adjustments to avoid crashing on macOS when running these layout tests: - Set an explicit bitmap image size for the initial full-page snapshot; on iOS, we automatically calculate the target bitmap size if it's otherwise unspecified, but on macOS, we appear to crash if it's set to an empty size. - Use `TextRecognitionLevel::Accurate` instead of `Fast` when validating per-paragraph snapshots, in the case where the full-page snapshot didn't already contain most of the words in the paragraph. This is necessary to keep several layout tests passing on macOS, due to the fast full-page snapshot missing some content in `debug-text-extraction-lightweight.html` and `debug-text-extraction-lightweight-discretionary.html`. * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _requestTextExtractionInternal:completion:]): (-[WKWebView _validateText:inFrame:inNode:completionHandler:]): Canonical link: https://commits.webkit.org/309496@main
8546a38 to
b5a77f0
Compare
Collaborator
|
Committed 309496@main (b5a77f0): https://commits.webkit.org/309496@main Reviewed commits have been landed. Closing PR #60865 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 ios-apple
b5a77f0
8546a38
🛠 win🧪 win-tests