Skip to content

REGRESSION (308504@main): Multiple fast/text-extraction tests crash on internal macOS test runners#60865

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
whsieh:eng/310189
Mar 18, 2026
Merged

REGRESSION (308504@main): Multiple fast/text-extraction tests crash on internal macOS test runners#60865
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
whsieh:eng/310189

Conversation

@whsieh
Copy link
Member

@whsieh whsieh commented Mar 18, 2026

b5a77f0

REGRESSION (308504@main): Multiple fast/text-extraction tests crash on internal macOS test runners
https://bugs.webkit.org/show_bug.cgi?id=310189
rdar://172823439

Reviewed by Abrar Rahman Protyasha.

Make several adjustments to avoid crashing on macOS when running these layout tests:

-   Set an explicit bitmap image size for the initial full-page snapshot; on iOS, we automatically
    calculate the target bitmap size if it's otherwise unspecified, but on macOS, we appear to crash
    if it's set to an empty size.

-   Use `TextRecognitionLevel::Accurate` instead of `Fast` when validating per-paragraph snapshots,
    in the case where the full-page snapshot didn't already contain most of the words in the
    paragraph. This is necessary to keep several layout tests passing on macOS, due to the fast
    full-page snapshot missing some content in `debug-text-extraction-lightweight.html` and
    `debug-text-extraction-lightweight-discretionary.html`.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _requestTextExtractionInternal:completion:]):
(-[WKWebView _validateText:inFrame:inNode:completionHandler:]):

Canonical link: https://commits.webkit.org/309496@main

8546a38

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win loading 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
loading 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh requested a review from cdumez as a code owner March 18, 2026 16:14
@whsieh whsieh self-assigned this Mar 18, 2026
@whsieh whsieh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 18, 2026
@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
@whsieh
Copy link
Member Author

whsieh commented Mar 18, 2026

Thanks for the review!

…n internal macOS test runners

https://bugs.webkit.org/show_bug.cgi?id=310189
rdar://172823439

Reviewed by Abrar Rahman Protyasha.

Make several adjustments to avoid crashing on macOS when running these layout tests:

-   Set an explicit bitmap image size for the initial full-page snapshot; on iOS, we automatically
    calculate the target bitmap size if it's otherwise unspecified, but on macOS, we appear to crash
    if it's set to an empty size.

-   Use `TextRecognitionLevel::Accurate` instead of `Fast` when validating per-paragraph snapshots,
    in the case where the full-page snapshot didn't already contain most of the words in the
    paragraph. This is necessary to keep several layout tests passing on macOS, due to the fast
    full-page snapshot missing some content in `debug-text-extraction-lightweight.html` and
    `debug-text-extraction-lightweight-discretionary.html`.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _requestTextExtractionInternal:completion:]):
(-[WKWebView _validateText:inFrame:inNode:completionHandler:]):

Canonical link: https://commits.webkit.org/309496@main
@webkit-commit-queue
Copy link
Collaborator

Committed 309496@main (b5a77f0): https://commits.webkit.org/309496@main

Reviewed commits have been landed. Closing PR #60865 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b5a77f0 into WebKit:main Mar 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
@whsieh whsieh deleted the eng/310189 branch March 18, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants