Skip to content

[AppKit Gestures] REGRESSION(309295@main): PDF form fields unexpectedly focused after automated input#60977

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
aprotyas:eng/310324
Mar 20, 2026
Merged

[AppKit Gestures] REGRESSION(309295@main): PDF form fields unexpectedly focused after automated input#60977
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
aprotyas:eng/310324

Conversation

@aprotyas
Copy link
Member

@aprotyas aprotyas commented Mar 20, 2026

14a440f

[AppKit Gestures] REGRESSION(309295@main): PDF form fields unexpectedly focused after automated input
https://bugs.webkit.org/show_bug.cgi?id=310324
rdar://172971256

Reviewed by Aditya Keerthi.

Automated input should not lead to PDF interactions. In 309295@main, the
mouse tracking GR we added undid this assumption since it continuously
produces a stream of mouse events that funnel through EventHandler into
the plugin. In this patch, we restore status quo by ducking out of the
way for automation inputs.

* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):

Canonical link: https://commits.webkit.org/309603@main

3e13c0b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner March 20, 2026 03:38
@aprotyas aprotyas self-assigned this Mar 20, 2026
@aprotyas aprotyas added the PDF For bugs in WebKit's built-in PDF support. label Mar 20, 2026
@aprotyas
Copy link
Member Author

Thank you for the reviews!

@aprotyas aprotyas added the merge-queue Applied to send a pull request to merge-queue label Mar 20, 2026
…ly focused after automated input

https://bugs.webkit.org/show_bug.cgi?id=310324
rdar://172971256

Reviewed by Aditya Keerthi.

Automated input should not lead to PDF interactions. In 309295@main, the
mouse tracking GR we added undid this assumption since it continuously
produces a stream of mouse events that funnel through EventHandler into
the plugin. In this patch, we restore status quo by ducking out of the
way for automation inputs.

* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):

Canonical link: https://commits.webkit.org/309603@main
@webkit-commit-queue
Copy link
Collaborator

Committed 309603@main (14a440f): https://commits.webkit.org/309603@main

Reviewed commits have been landed. Closing PR #60977 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 14a440f into WebKit:main Mar 20, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 20, 2026
@aprotyas aprotyas deleted the eng/310324 branch March 20, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PDF For bugs in WebKit's built-in PDF support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants