Skip to content

Can't analyze HEIC images on web app, force converts to JPEG#61222

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
J0pan:quirk-uhc-heic-transcoding
Mar 24, 2026
Merged

Can't analyze HEIC images on web app, force converts to JPEG#61222
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
J0pan:quirk-uhc-heic-transcoding

Conversation

@J0pan
Copy link
Copy Markdown
Contributor

@J0pan J0pan commented Mar 24, 2026

b5cac06

Can't analyze HEIC images on web app, force converts to JPEG
https://bugs.webkit.org/show_bug.cgi?id=310605
rdar://173206598

Reviewed by Aditya Keerthi and Tim Horton.

Moved the change implemented here: https://bugs.webkit.org/show_bug.cgi?id=292350
to a quirk specifically for uhc.com.

Uhc.com was the original domain that the radar was filed for: rdar://97210206

* Source/WebCore/page/Quirks.cpp:
* Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::shouldTranscodeHeicImagesForPage):
(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType):
(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):

Canonical link: https://commits.webkit.org/309872@main

9f61e99

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ⏳ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ⏳ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@J0pan J0pan requested a review from cdumez as a code owner March 24, 2026 05:36
@karlcow
Copy link
Copy Markdown
Member

karlcow commented Mar 24, 2026

You rock @J0pan Thanks for the quick fix!

@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

macOS Safer C++ Build #88314 (ca92935)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 24, 2026
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

iOS Safer C++ Build #6186 (ca92935)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

@J0pan J0pan changed the title Can't analyze HEIC images on web app, force converts to JPEG Need a short description (OOPS!). Mar 24, 2026
@J0pan J0pan force-pushed the quirk-uhc-heic-transcoding branch from ca92935 to 9141abf Compare March 24, 2026 17:10
@pxlcoder pxlcoder added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 24, 2026
@J0pan J0pan changed the title Need a short description (OOPS!). Can't analyze HEIC images on web app, force converts to JPEG Mar 24, 2026
@J0pan J0pan force-pushed the quirk-uhc-heic-transcoding branch from 9141abf to 9f61e99 Compare March 24, 2026 17:24
@pxlcoder pxlcoder added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 24, 2026
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 24, 2026
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

Safe-Merge-Queue: Build #87602.

https://bugs.webkit.org/show_bug.cgi?id=310605
rdar://173206598

Reviewed by Aditya Keerthi and Tim Horton.

Moved the change implemented here: https://bugs.webkit.org/show_bug.cgi?id=292350
to a quirk specifically for uhc.com.

Uhc.com was the original domain that the radar was filed for: rdar://97210206

* Source/WebCore/page/Quirks.cpp:
* Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::shouldTranscodeHeicImagesForPage):
(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType):
(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
(WebKit::WebPasteboardProxy::informationForItemAtIndex):

Canonical link: https://commits.webkit.org/309872@main
@webkit-commit-queue webkit-commit-queue force-pushed the quirk-uhc-heic-transcoding branch from 9f61e99 to b5cac06 Compare March 24, 2026 22:52
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 309872@main (b5cac06): https://commits.webkit.org/309872@main

Reviewed commits have been landed. Closing PR #61222 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b5cac06 into WebKit:main Mar 24, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants