Skip to content

[IndexedDB API] Support IDBGetAllOptions in IDBIndex::getAllKeys() #61317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webkit-commit-queue merged 1 commit into from
Mar 27, 2026
Merged

[IndexedDB API] Support IDBGetAllOptions in IDBIndex::getAllKeys() #61317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions ...ts/imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@

FAIL Single item get Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Empty object store Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all generated keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=10 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get upper excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get lower excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range (generated) with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Non existent key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=0 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Max value count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where first key < upperBound Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where lowerBound < last key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve multiEntry key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve one key multiple values Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: next Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prev Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: nextunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prevunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction and query Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction, query and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys with both options and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
PASS Single item get
PASS Empty object store
PASS Get all keys
PASS Get all generated keys
PASS maxCount=10
PASS Get bound range
PASS Get bound range with maxCount
PASS Get upper excluded
PASS Get lower excluded
PASS Get bound range (generated) with maxCount
PASS Non existent key
PASS maxCount=0
PASS Max value count
PASS Query with empty range where first key < upperBound
PASS Query with empty range where lowerBound < last key
PASS Retrieve multiEntry key
PASS Retrieve one key multiple values
PASS Direction: next
PASS Direction: prev
PASS Direction: nextunique
PASS Direction: prevunique
PASS Direction and query
PASS Direction, query and count
PASS Get all keys with both options and count
PASS Get all keys with invalid query keys

48 changes: 24 additions & 24 deletions ...c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any.serviceworker-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@

FAIL Single item get Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Empty object store Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all generated keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=10 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get upper excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get lower excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range (generated) with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Non existent key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=0 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Max value count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where first key < upperBound Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where lowerBound < last key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve multiEntry key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve one key multiple values Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: next Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prev Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: nextunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prevunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction and query Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction, query and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys with both options and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
PASS Single item get
PASS Empty object store
PASS Get all keys
PASS Get all generated keys
PASS maxCount=10
PASS Get bound range
PASS Get bound range with maxCount
PASS Get upper excluded
PASS Get lower excluded
PASS Get bound range (generated) with maxCount
PASS Non existent key
PASS maxCount=0
PASS Max value count
PASS Query with empty range where first key < upperBound
PASS Query with empty range where lowerBound < last key
PASS Retrieve multiEntry key
PASS Retrieve one key multiple values
PASS Direction: next
PASS Direction: prev
PASS Direction: nextunique
PASS Direction: prevunique
PASS Direction and query
PASS Direction, query and count
PASS Get all keys with both options and count
PASS Get all keys with invalid query keys

48 changes: 24 additions & 24 deletions ...3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any.sharedworker-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@

FAIL Single item get Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Empty object store Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all generated keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=10 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get upper excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get lower excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range (generated) with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Non existent key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=0 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Max value count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where first key < upperBound Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where lowerBound < last key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve multiEntry key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve one key multiple values Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: next Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prev Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: nextunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prevunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction and query Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction, query and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys with both options and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
PASS Single item get
PASS Empty object store
PASS Get all keys
PASS Get all generated keys
PASS maxCount=10
PASS Get bound range
PASS Get bound range with maxCount
PASS Get upper excluded
PASS Get lower excluded
PASS Get bound range (generated) with maxCount
PASS Non existent key
PASS maxCount=0
PASS Max value count
PASS Query with empty range where first key < upperBound
PASS Query with empty range where lowerBound < last key
PASS Retrieve multiEntry key
PASS Retrieve one key multiple values
PASS Direction: next
PASS Direction: prev
PASS Direction: nextunique
PASS Direction: prevunique
PASS Direction and query
PASS Direction, query and count
PASS Get all keys with both options and count
PASS Get all keys with invalid query keys

48 changes: 24 additions & 24 deletions ...rted/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys-options.any.worker-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@

FAIL Single item get Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Empty object store Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all generated keys Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=10 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get upper excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get lower excluded Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get bound range (generated) with maxCount Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Non existent key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL maxCount=0 Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Max value count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where first key < upperBound Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Query with empty range where lowerBound < last key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve multiEntry key Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Retrieve one key multiple values Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: next Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prev Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: nextunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction: prevunique Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction and query Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Direction, query and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
FAIL Get all keys with both options and count Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key.
PASS Single item get
PASS Empty object store
PASS Get all keys
PASS Get all generated keys
PASS maxCount=10
PASS Get bound range
PASS Get bound range with maxCount
PASS Get upper excluded
PASS Get lower excluded
PASS Get bound range (generated) with maxCount
PASS Non existent key
PASS maxCount=0
PASS Max value count
PASS Query with empty range where first key < upperBound
PASS Query with empty range where lowerBound < last key
PASS Retrieve multiEntry key
PASS Retrieve one key multiple values
PASS Direction: next
PASS Direction: prev
PASS Direction: nextunique
PASS Direction: prevunique
PASS Direction and query
PASS Direction, query and count
PASS Get all keys with both options and count
PASS Get all keys with invalid query keys

4 changes: 1 addition & 3 deletions ...ests/imported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.any-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ FAIL IDBObjectStore getAllRecords() method with throwing/invalid keys assert_thr
FAIL IDBIndex getAll() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAll' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
FAIL IDBIndex getAllKeys() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
PASS IDBIndex getAllKeys() method with throwing/invalid keys
FAIL IDBIndex getAllRecords() method with throwing/invalid keys assert_throws_dom: options query key conversion with invalid key should throw DataError function "() => {
receiver[method]({query: invalid_key});
}" threw object "NotSupportedError: getAllRecords is not yet supported" that is not a DOMException DataError: property "code" is equal to 9, expected 0
Expand Down
4 changes: 1 addition & 3 deletions ...w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.any.serviceworker-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ FAIL IDBObjectStore getAllRecords() method with throwing/invalid keys assert_thr
FAIL IDBIndex getAll() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAll' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
FAIL IDBIndex getAllKeys() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
PASS IDBIndex getAllKeys() method with throwing/invalid keys
FAIL IDBIndex getAllRecords() method with throwing/invalid keys assert_throws_dom: options query key conversion with invalid key should throw DataError function "() => {
receiver[method]({query: invalid_key});
}" threw object "NotSupportedError: getAllRecords is not yet supported" that is not a DOMException DataError: property "code" is equal to 9, expected 0
Expand Down
4 changes: 1 addition & 3 deletions .../w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.any.sharedworker-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ FAIL IDBObjectStore getAllRecords() method with throwing/invalid keys assert_thr
FAIL IDBIndex getAll() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAll' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
FAIL IDBIndex getAllKeys() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
PASS IDBIndex getAllKeys() method with throwing/invalid keys
FAIL IDBIndex getAllRecords() method with throwing/invalid keys assert_throws_dom: options query key conversion with invalid key should throw DataError function "() => {
receiver[method]({query: invalid_key});
}" threw object "NotSupportedError: getAllRecords is not yet supported" that is not a DOMException DataError: property "code" is equal to 9, expected 0
Expand Down
4 changes: 1 addition & 3 deletions ...ported/w3c/web-platform-tests/IndexedDB/key-conversion-exceptions.any.worker-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ FAIL IDBObjectStore getAllRecords() method with throwing/invalid keys assert_thr
FAIL IDBIndex getAll() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAll' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
FAIL IDBIndex getAllKeys() method with throwing/invalid keys assert_throws_exactly: options query key conversion with throwing getter should rethrow function "() => {
receiver[method]({query: key});
}" threw object "DataError: Failed to execute 'getAllKeys' on 'IDBIndex': The parameter is not a valid key." but we expected it to throw object "getter: throwing from getter"
PASS IDBIndex getAllKeys() method with throwing/invalid keys
FAIL IDBIndex getAllRecords() method with throwing/invalid keys assert_throws_dom: options query key conversion with invalid key should throw DataError function "() => {
receiver[method]({query: invalid_key});
}" threw object "NotSupportedError: getAllRecords is not yet supported" that is not a DOMException DataError: property "code" is equal to 9, expected 0
Expand Down
Loading