Skip to content

RTCRtpSender.setParameters should clear parameters that were unset by the web app#61676

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
youennf:eng/RTCRtpSender-setParameters-should-clear-parameters-that-were-unset-by-the-web-app
Mar 31, 2026
Merged

RTCRtpSender.setParameters should clear parameters that were unset by the web app#61676
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
youennf:eng/RTCRtpSender-setParameters-should-clear-parameters-that-were-unset-by-the-web-app

Conversation

@youennf
Copy link
Copy Markdown
Contributor

@youennf youennf commented Mar 30, 2026

9261d55

RTCRtpSender.setParameters should clear parameters that were unset by the web app
rdar://173678165
https://bugs.webkit.org/show_bug.cgi?id=311085

Reviewed by Eric Carlson.

Previously, we were updating the rtc parameters based on WebCore parameters if a WebCore parameter is defined.
We add the ability to unset the rtc parameter fields for which WebCore parameter fields have been unset.

Covered by rebased WPT test.
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::updateRTCRtpSendParameters):

Canonical link: https://commits.webkit.org/310286@main

ce1fcf1

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ❌ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@youennf youennf self-assigned this Mar 30, 2026
@youennf youennf added the WebRTC For bugs in WebRTC label Mar 30, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 30, 2026
@youennf youennf force-pushed the eng/RTCRtpSender-setParameters-should-clear-parameters-that-were-unset-by-the-web-app branch from cbea2bc to ce1fcf1 Compare March 30, 2026 12:34
@youennf youennf removed the merging-blocked Applied to prevent a change from being merged label Mar 30, 2026
@youennf youennf marked this pull request as ready for review March 30, 2026 13:07
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2026
… the web app

rdar://173678165
https://bugs.webkit.org/show_bug.cgi?id=311085

Reviewed by Eric Carlson.

Previously, we were updating the rtc parameters based on WebCore parameters if a WebCore parameter is defined.
We add the ability to unset the rtc parameter fields for which WebCore parameter fields have been unset.

Covered by rebased WPT test.
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::updateRTCRtpSendParameters):

Canonical link: https://commits.webkit.org/310286@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/RTCRtpSender-setParameters-should-clear-parameters-that-were-unset-by-the-web-app branch from ce1fcf1 to 9261d55 Compare March 31, 2026 06:34
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 310286@main (9261d55): https://commits.webkit.org/310286@main

Reviewed commits have been landed. Closing PR #61676 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9261d55 into WebKit:main Mar 31, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebRTC For bugs in WebRTC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants