RTCRtpSender.setParameters should clear parameters that were unset by the web app#61676
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash cbea2bc) Details |
cbea2bc to
ce1fcf1
Compare
Collaborator
|
EWS run on current version of this PR (hash ce1fcf1) Details |
eric-carlson
approved these changes
Mar 30, 2026
… the web app rdar://173678165 https://bugs.webkit.org/show_bug.cgi?id=311085 Reviewed by Eric Carlson. Previously, we were updating the rtc parameters based on WebCore parameters if a WebCore parameter is defined. We add the ability to unset the rtc parameter fields for which WebCore parameter fields have been unset. Covered by rebased WPT test. * Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp: (WebCore::updateRTCRtpSendParameters): Canonical link: https://commits.webkit.org/310286@main
ce1fcf1 to
9261d55
Compare
Collaborator
|
Committed 310286@main (9261d55): https://commits.webkit.org/310286@main Reviewed commits have been landed. Closing PR #61676 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9261d55
ce1fcf1