[GStreamer] Rebrand colorspace handling to common facilities #6169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
added
Platform
Collaborator
|
EWS run on previous version of this PR (hash 2519369)
|
calvaris
approved these changes
Nov 7, 2022
Collaborator
|
EWS run on current version of this PR (hash 9afbbfd)
|
https://bugs.webkit.org/show_bug.cgi?id=247524 Reviewed by Xabier Rodriguez-Calvar. We had some basic GstVideoInfo -> PlatformVideoColorSpace conversion in VideoTrackPrivateGStreamer. This now lives in GStreamerCommon along with a GstCaps -> PlatformVideoColorSpace and PlatformVideoColorSpace -> GstCaps utilities. Those will be useful to improve the VideoFrameGStreamer implementation for the WebCodecs backend. * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::videoColorSpaceFromCaps): (WebCore::videoColorSpaceFromInfo): (WebCore::fillVideoInfoColorimetryFromColorSpace): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: * Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: (WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps): Canonical link: https://commits.webkit.org/256396@main
webkit-early-warning-system
force-pushed
the
eng/247524
branch
from
9afbbfd to
2a9d6e2
Compare
Collaborator
|
Committed 256396@main (2a9d6e2): https://commits.webkit.org/256396@main Reviewed commits have been landed. Closing PR #6169 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2a9d6e2
9afbbfd
🛠 🧪 win🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk1🧪 mac-AS-debug-wk2