REGRESSION(309194@main): broke Web Inspector custom <select> menus#61825
Closed
annevk wants to merge 1 commit into
Closed
REGRESSION(309194@main): broke Web Inspector custom <select> menus#61825annevk wants to merge 1 commit into
annevk wants to merge 1 commit into
Conversation
https://bugs.webkit.org/show_bug.cgi?id=311262 rdar://173851743 Reviewed by NOBODY (OOPS!). Web Inspector relies on a synthetic mousedown event opening <select>. As working around this appears involved, we reduce the scope of 309194@main to only target base-select <select> elements for now. We add a novel test for this specific scenario as the tests converted in 309194@main were actually testing something else entirely so keeping them focused on those other aspects seems best.
Collaborator
|
EWS run on current version of this PR (hash 9c992f6) Details
|
Contributor
Author
|
This might not be needed given #61829. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-apple
9c992f6
9c992f6