Skip to content

Some main frame and same-site loads are blocked with scriptTrackingPrivacyNetworkRequestBlockingLatchEnabled#61838

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
charliewolfe:eng/Some-main-frame-and-same-site-loads-are-blocked-with-scriptTrackingPrivacyNetworkRequestBlockingLatchEnabled
Apr 7, 2026
Merged

Some main frame and same-site loads are blocked with scriptTrackingPrivacyNetworkRequestBlockingLatchEnabled#61838
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
charliewolfe:eng/Some-main-frame-and-same-site-loads-are-blocked-with-scriptTrackingPrivacyNetworkRequestBlockingLatchEnabled

Conversation

@charliewolfe
Copy link
Copy Markdown
Member

@charliewolfe charliewolfe commented Apr 1, 2026

b244674

Some main frame and same-site loads are blocked with `scriptTrackingPrivacyNetworkRequestBlockingLatchEnabled`
https://bugs.webkit.org/show_bug.cgi?id=311274
rdar://173870962

Reviewed by Matthew Finkel.

This protection shouldn’t apply when the site has been loaded into the main frame.

Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/ScriptTrackingPrivacyTests.mm

* Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::shouldBlockForTrackingPolicy):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::addParametersShared):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ScriptTrackingPrivacyTests.mm:
(TestWebKitAPI::(ScriptTrackingPrivacyTests, SameSiteFetchNotBlocked)):
(TestWebKitAPI::(ScriptTrackingPrivacyTests, MainFrameNavigationNotBlocked)):

Canonical link: https://commits.webkit.org/310741@main

d6e029e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 💥 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests ❌ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@charliewolfe charliewolfe requested a review from cdumez as a code owner April 1, 2026 18:14
@charliewolfe charliewolfe self-assigned this Apr 1, 2026
@charliewolfe charliewolfe added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 1, 2026
@charliewolfe charliewolfe requested a review from sysrqb April 1, 2026 18:14
@charliewolfe charliewolfe added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 7, 2026
…rivacyNetworkRequestBlockingLatchEnabled`

https://bugs.webkit.org/show_bug.cgi?id=311274
rdar://173870962

Reviewed by Matthew Finkel.

This protection shouldn’t apply when the site has been loaded into the main frame.

Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/ScriptTrackingPrivacyTests.mm

* Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::shouldBlockForTrackingPolicy):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::addParametersShared):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ScriptTrackingPrivacyTests.mm:
(TestWebKitAPI::(ScriptTrackingPrivacyTests, SameSiteFetchNotBlocked)):
(TestWebKitAPI::(ScriptTrackingPrivacyTests, MainFrameNavigationNotBlocked)):

Canonical link: https://commits.webkit.org/310741@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Some-main-frame-and-same-site-loads-are-blocked-with-scriptTrackingPrivacyNetworkRequestBlockingLatchEnabled branch from d6e029e to b244674 Compare April 7, 2026 22:00
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 310741@main (b244674): https://commits.webkit.org/310741@main

Reviewed commits have been landed. Closing PR #61838 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b244674 into WebKit:main Apr 7, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants