Skip to content

Implement load and store for Memory64 in the OMG tier#61861

Open
colelao wants to merge 1 commit intoWebKit:mainfrom
colelao:omg-memory64
Open

Implement load and store for Memory64 in the OMG tier#61861
colelao wants to merge 1 commit intoWebKit:mainfrom
colelao:omg-memory64

Conversation

@colelao
Copy link
Copy Markdown
Contributor

@colelao colelao commented Apr 1, 2026 •
edited by webkit-early-warning-system
Loading

ef96937

Implement load and store for Memory64 in the OMG tier
https://bugs.webkit.org/show_bug.cgi?id=311301
rdar://173894182

Reviewed by NOBODY (OOPS!).

This adds support for load and store in memory64
in the WebAssembly OMG tier.

* JSTests/wasm/stress/memory64-bulk-memory.js:
* JSTests/wasm/stress/memory64-grow-and-size.js:
* JSTests/wasm/stress/memory64-load-and-store.js:
* JSTests/wasm/stress/memory64-overflow.js:
* JSTests/wasm/stress/memory64-write-to-address-over-4-gigs.js:
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::OMGIRGenerator::load):
(JSC::Wasm::OMGIRGenerator::store):

ef96937

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ❌ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@colelao colelao self-assigned this Apr 1, 2026
@colelao colelao added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Apr 1, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 1, 2026 •
edited
Loading

EWS run on previous version of this PR (hash e59a3d8)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios ❌ 🛠 mac   🛠 wpe   🛠 win loading 🛠 ios-apple
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   🧪 api-wpe loading 🛠 vision-apple
❌ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug   🛠 gtk3-libwebrtc
  🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🛠 gtk
❌ 🛠 🧪 jsc-debug-arm64   🛠 ios-safer-cpp ❌ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
  🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress loading 🛠 playstation
❌ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
  🛠 tv   🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 1, 2026
@colelao colelao removed the merging-blocked Applied to prevent a change from being merged label Apr 1, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 1, 2026
@colelao colelao changed the title Need a short description (OOPS!). Implement Memory64 in the OMG tier Apr 1, 2026
@colelao colelao added WebAssembly For bugs in JavaScript WebAssembly and removed HTML Editing For bugs in HTML editing support (including designMode and contentEditable). labels Apr 1, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 1, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 3933d69)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 gtk3-libwebrtc
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1   🛠 gtk
  🛠 🧪 jsc-debug-arm64   🛠 ios-safer-cpp   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 vision-sim   🧪 mac-wk2-stress   🛠 playstation
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 jsc-armv7
  🛠 tv   🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@colelao colelao added skip-ews Applied to prevent a change from being run on EWS and removed merging-blocked Applied to prevent a change from being merged skip-ews Applied to prevent a change from being run on EWS labels Apr 1, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 2, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 354a24b)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
❌ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
❌ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 3, 2026
@colelao colelao removed the merging-blocked Applied to prevent a change from being merged label Apr 3, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 3, 2026 •
edited
Loading

EWS run on previous version of this PR (hash ab59067)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 gtk3-libwebrtc
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1   🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64   🛠 ios-safer-cpp   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🛠 playstation
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 jsc-armv7
  🛠 tv   🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@colelao colelao changed the title Implement Memory64 in the OMG tier Implement load and store for Memory64 in the OMG tier Apr 3, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 3, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 2475808)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@colelao colelao marked this pull request as ready for review April 3, 2026 22:32
@colelao colelao requested a review from a team as a code owner April 3, 2026 22:32
@colelao colelao requested a review from kmiller68 April 3, 2026 22:40
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 4, 2026
kmiller68
kmiller68 reviewed Apr 6, 2026
View reviewed changes
@colelao colelao requested a review from kmiller68 April 6, 2026 16:53
@colelao colelao removed the merging-blocked Applied to prevent a change from being merged label Apr 6, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 6, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 57b1130)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

kmiller68
kmiller68 reviewed Apr 6, 2026
View reviewed changes
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 7, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 5f3d883)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe   🛠 win loading 🛠 ios-apple
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe loading 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug   🛠 gtk3-libwebrtc
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
  🛠 🧪 jsc-debug-arm64   🛠 ios-safer-cpp   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 vision-sim   🧪 mac-wk2-stress   🛠 playstation
  🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
  🛠 tv ✅ 🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@colelao colelao requested a review from kmiller68 April 7, 2026 18:18
@colelao
Implement load and store for Memory64 in the OMG tier
ef96937 
https://bugs.webkit.org/show_bug.cgi?id=311301
rdar://173894182

Reviewed by NOBODY (OOPS!).

This adds support for load and store in memory64
in the WebAssembly OMG tier.

* JSTests/wasm/stress/memory64-bulk-memory.js:
* JSTests/wasm/stress/memory64-grow-and-size.js:
* JSTests/wasm/stress/memory64-load-and-store.js:
* JSTests/wasm/stress/memory64-overflow.js:
* JSTests/wasm/stress/memory64-write-to-address-over-4-gigs.js:
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::OMGIRGenerator::load):
(JSC::Wasm::OMGIRGenerator::store):
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 7, 2026 •
edited
Loading

EWS run on current version of this PR (hash ef96937)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ❌ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmiller68 kmiller68 Awaiting requested review from kmiller68

Assignees

@colelao colelao

Labels

WebAssembly For bugs in JavaScript WebAssembly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@colelao @webkit-early-warning-system @kmiller68 @webkit-ews-buildbot