Drop redundant remaining < maxTokenLength checks in Lexer.cpp#61881
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 2, 2026
Merged
Drop redundant remaining < maxTokenLength checks in Lexer.cpp#61881webkit-commit-queue merged 1 commit intoWebKit:mainfrom
remaining < maxTokenLength checks in Lexer.cpp#61881webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash d12a3ee) Details
|
Constellation
approved these changes
Apr 2, 2026
https://bugs.webkit.org/show_bug.cgi?id=311319 Reviewed by Yusuke Suzuki. The outer `if` check already checks this so the condition will always be true and can be removed. * Source/JavaScriptCore/parser/Lexer.cpp: (JSC::Lexer<Latin1Character>::parseIdentifier): (JSC::Lexer<char16_t>::parseIdentifier): Canonical link: https://commits.webkit.org/310427@main
d12a3ee to
c446f2d
Compare
Collaborator
|
Committed 310427@main (c446f2d): https://commits.webkit.org/310427@main Reviewed commits have been landed. Closing PR #61881 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c446f2d
d12a3ee
🛠 win🧪 win-tests🧪 api-mac-debug🛠 ios-safer-cpp