Skip to content

Drop redundant remaining < maxTokenLength checks in Lexer.cpp#61881

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:311319_Lexer_dead_code
Apr 2, 2026
Merged

Drop redundant remaining < maxTokenLength checks in Lexer.cpp#61881
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:311319_Lexer_dead_code

Conversation

@cdumez
Copy link
Copy Markdown
Contributor

@cdumez cdumez commented Apr 2, 2026

@cdumez cdumez self-assigned this Apr 2, 2026
@cdumez cdumez added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 2, 2026
@cdumez cdumez marked this pull request as ready for review April 2, 2026 07:18
@cdumez cdumez requested a review from a team as a code owner April 2, 2026 07:18
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 2, 2026
https://bugs.webkit.org/show_bug.cgi?id=311319

Reviewed by Yusuke Suzuki.

The outer `if` check already checks this so the condition will always
be true and can be removed.

* Source/JavaScriptCore/parser/Lexer.cpp:
(JSC::Lexer<Latin1Character>::parseIdentifier):
(JSC::Lexer<char16_t>::parseIdentifier):

Canonical link: https://commits.webkit.org/310427@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 310427@main (c446f2d): https://commits.webkit.org/310427@main

Reviewed commits have been landed. Closing PR #61881 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c446f2d into WebKit:main Apr 2, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants