base-select option hover style clipping with rotated transforms#61963
Closed
annevk wants to merge 1 commit intoWebKit:mainfrom
Closed
base-select option hover style clipping with rotated transforms#61963annevk wants to merge 1 commit intoWebKit:mainfrom
annevk wants to merge 1 commit intoWebKit:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
d9e9800 to
0ce2612
Compare
This comment was marked as outdated.
This comment was marked as outdated.
0ce2612 to
6546918
Compare
Collaborator
|
EWS run on previous version of this PR (hash 6546918) Details |
smfr
reviewed
Apr 3, 2026
| // the child block ourselves. | ||
| if (renderer.hasSelfPaintingLayer() && !hasFilter()) | ||
| if (renderer.hasSelfPaintingLayer() && !hasFilter() | ||
| && (!renderer.hasTransformRelatedProperty() || hasNonVisibleOverflow())) |
Contributor
There was a problem hiding this comment.
This includes transformStyle3D and perspective which probably aren't relevant there. Maybe we need a version that only looks for actual, non-identity transforms.
https://bugs.webkit.org/show_bug.cgi?id=311402 rdar://171933742 Reviewed by NOBODY (OOPS!). In https://patrickbrosset.com/lab/custom-select/folders/ the options drawn outside the ::picker(select) rectangle have their :hover effect clipped by the rectangle because RenderBox::addOverflowWithRendererOffset() didn't account for visible overflow from 2D transforms. This is tested by the first test below. We attempt to offset the impact of this change a bit with ExcludeSelfPaintingChildOverflow. Additionally, HTMLOptionElement::willResetComputedStyle() caused repaint() to be invoked way too often for appearance: base <select> elements. This is tested by the second test. Tests: fast/repaint/overflow-visible-transformed-child-repaint.html fast/forms/select/base/select-rotated-option-hover-repaint.html
6546918 to
de2f0a7
Compare
Collaborator
|
EWS run on current version of this PR (hash de2f0a7) Details |
Contributor
Author
|
I think I found a more targeted approach: #62087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
de2f0a7
de2f0a7