Skip to content

Remove HTMLOptionElement::willResetComputedStyle()#62077

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
annevk:eng/Test-what-HTMLOptionElement-willResetComputedStyle-is-for
Apr 6, 2026
Merged

Remove HTMLOptionElement::willResetComputedStyle()#62077
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
annevk:eng/Test-what-HTMLOptionElement-willResetComputedStyle-is-for

Conversation

@annevk
Copy link
Copy Markdown
Contributor

@annevk annevk commented Apr 5, 2026

4b927e4

Remove HTMLOptionElement::willResetComputedStyle()
https://bugs.webkit.org/show_bug.cgi?id=311524

Reviewed by Chris Dumez.

Back in 2011, we had bug 49790 about the background property not
working for <option>s when set through script. This was fixed in
67043@main through a repaint() hack. And a regression test was added
that's still functional and passing:

    fast/repaint/select-option-background-color.html

In 2012 bug 100397 performed some refactoring and added a FIXME.

In 2014 bug 135938 there was more refactoring creating the current
setup.

With the way we handle style invalidation today this workaround appears
no longer to be needed.

Canonical link: https://commits.webkit.org/310623@main

86eead6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ❌ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ❌ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Apr 5, 2026
@annevk annevk added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Apr 5, 2026
@annevk annevk changed the title Test what HTMLOptionElement::willResetComputedStyle() is for Remove HTMLOptionElement::willResetComputedStyle() Apr 5, 2026
@annevk annevk force-pushed the eng/Test-what-HTMLOptionElement-willResetComputedStyle-is-for branch from 1d85683 to 2523e4c Compare April 5, 2026 14:46
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 5, 2026
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Apr 5, 2026
@annevk annevk force-pushed the eng/Test-what-HTMLOptionElement-willResetComputedStyle-is-for branch from 2523e4c to 86eead6 Compare April 5, 2026 21:07
@annevk annevk marked this pull request as ready for review April 6, 2026 05:04
@annevk annevk requested review from cdumez and rniwa as code owners April 6, 2026 05:04
@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 6, 2026
https://bugs.webkit.org/show_bug.cgi?id=311524

Reviewed by Chris Dumez.

Back in 2011, we had bug 49790 about the background property not
working for <option>s when set through script. This was fixed in
67043@main through a repaint() hack. And a regression test was added
that's still functional and passing:

    fast/repaint/select-option-background-color.html

In 2012 bug 100397 performed some refactoring and added a FIXME.

In 2014 bug 135938 there was more refactoring creating the current
setup.

With the way we handle style invalidation today this workaround appears
no longer to be needed.

Canonical link: https://commits.webkit.org/310623@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Test-what-HTMLOptionElement-willResetComputedStyle-is-for branch from 86eead6 to 4b927e4 Compare April 6, 2026 05:57
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 310623@main (4b927e4): https://commits.webkit.org/310623@main

Reviewed commits have been landed. Closing PR #62077 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4b927e4 into WebKit:main Apr 6, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 6, 2026
@annevk annevk deleted the eng/Test-what-HTMLOptionElement-willResetComputedStyle-is-for branch April 6, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants