Remove HTMLOptionElement::willResetComputedStyle()#62077
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 6, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 1d85683) Details |
1d85683 to
2523e4c
Compare
Collaborator
|
EWS run on previous version of this PR (hash 2523e4c) Details
|
2523e4c to
86eead6
Compare
Collaborator
|
EWS run on current version of this PR (hash 86eead6) Details |
cdumez
approved these changes
Apr 6, 2026
https://bugs.webkit.org/show_bug.cgi?id=311524 Reviewed by Chris Dumez. Back in 2011, we had bug 49790 about the background property not working for <option>s when set through script. This was fixed in 67043@main through a repaint() hack. And a regression test was added that's still functional and passing: fast/repaint/select-option-background-color.html In 2012 bug 100397 performed some refactoring and added a FIXME. In 2014 bug 135938 there was more refactoring creating the current setup. With the way we handle style invalidation today this workaround appears no longer to be needed. Canonical link: https://commits.webkit.org/310623@main
86eead6 to
4b927e4
Compare
Collaborator
|
Committed 310623@main (4b927e4): https://commits.webkit.org/310623@main Reviewed commits have been landed. Closing PR #62077 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4b927e4
86eead6