Skip to content

AX: Add helper to AXTextMarkerRange to get the text-run form of the start and end markers, allowing for code de-duplication#62162

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
twilco:eng/AX-Add-helper-to-AXTextMarkerRange-to-get-the-text-run-form-of-the-start-and-end-markers-allowing-for-code-de-duplication
Apr 7, 2026
Merged

AX: Add helper to AXTextMarkerRange to get the text-run form of the start and end markers, allowing for code de-duplication#62162
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
twilco:eng/AX-Add-helper-to-AXTextMarkerRange-to-get-the-text-run-form-of-the-start-and-end-markers-allowing-for-code-de-duplication

Conversation

@twilco
Copy link
Copy Markdown
Contributor

@twilco twilco commented Apr 7, 2026 •
edited by webkit-early-warning-system
Loading

3bad0b8

AX: Add helper to AXTextMarkerRange to get the text-run form of the start and end markers, allowing for code de-duplication
https://bugs.webkit.org/show_bug.cgi?id=311610
rdar://174209754

Reviewed by Joshua Hoffman.

* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarkerRange::toString const):
(WebCore::AXTextMarkerRange::toValidTextRunMarkers const):
(WebCore::AXTextMarkerRange::viewportRelativeFrame const):
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm:
(WebCore::AXTextMarkerRange::toAttributedString const):

Canonical link: https://commits.webkit.org/310707@main

10658f9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@twilco twilco self-assigned this Apr 7, 2026
@twilco twilco added the Accessibility For bugs related to accessibility. label Apr 7, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 7, 2026 •
edited
Loading

EWS run on current version of this PR (hash 10658f9)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe loading 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

hoffmanjoshua
hoffmanjoshua approved these changes Apr 7, 2026
View reviewed changes
Comment thread Source/WebCore/accessibility/AXTextMarker.cpp
Copy link
Copy Markdown
Contributor

@hoffmanjoshua hoffmanjoshua Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@twilco twilco added the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2026
@twilco
AX: Add helper to AXTextMarkerRange to get the text-run form of the s…
3bad0b8 
…tart and end markers, allowing for code de-duplication

https://bugs.webkit.org/show_bug.cgi?id=311610
rdar://174209754

Reviewed by Joshua Hoffman.

* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarkerRange::toString const):
(WebCore::AXTextMarkerRange::toValidTextRunMarkers const):
(WebCore::AXTextMarkerRange::viewportRelativeFrame const):
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm:
(WebCore::AXTextMarkerRange::toAttributedString const):

Canonical link: https://commits.webkit.org/310707@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/AX-Add-helper-to-AXTextMarkerRange-to-get-the-text-run-form-of-the-start-and-end-markers-allowing-for-code-de-duplication branch from 10658f9 to 3bad0b8 Compare April 7, 2026 15:29
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Apr 7, 2026

Committed 310707@main (3bad0b8): https://commits.webkit.org/310707@main

Reviewed commits have been landed. Closing PR #62162 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3bad0b8 into WebKit:main Apr 7, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffmanjoshua hoffmanjoshua hoffmanjoshua approved these changes

@minorninth minorninth Awaiting requested review from minorninth minorninth is a code owner

@fleizach fleizach Awaiting requested review from fleizach fleizach is a code owner

@AndresGonzalezApple AndresGonzalezApple Awaiting requested review from AndresGonzalezApple AndresGonzalezApple is a code owner

Assignees

@twilco twilco

Labels

Accessibility For bugs related to accessibility.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@twilco @webkit-early-warning-system @webkit-commit-queue @hoffmanjoshua