Skip to content

[WPE] Do not try to enable MSAA for tile buffers#62185

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
carlosgcampos:wpe-skia-no-msaa-tile-buffers
Apr 13, 2026
Merged

[WPE] Do not try to enable MSAA for tile buffers#62185
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
carlosgcampos:wpe-skia-no-msaa-tile-buffers

Conversation

@carlosgcampos
Copy link
Copy Markdown
Contributor

@carlosgcampos carlosgcampos commented Apr 7, 2026

bdc29c5

[WPE] Do not try to enable MSAA for tile buffers
https://bugs.webkit.org/show_bug.cgi?id=311637

Reviewed by Nikolas Zimmermann.

We create the SkSurface for tile buffers with an external texture
created with BitmapTexture, but MSAA doesn't work for surfaces created
from an external texture.

* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedTileBuffer.cpp:
(WebCore::CoordinatedAcceleratedTileBuffer::tryEnsureSurface):

Canonical link: https://commits.webkit.org/311059@main

2363fe6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@carlosgcampos carlosgcampos requested a review from magomez as a code owner April 7, 2026 10:13
@carlosgcampos carlosgcampos self-assigned this Apr 7, 2026
@carlosgcampos carlosgcampos added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 7, 2026
@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 13, 2026
https://bugs.webkit.org/show_bug.cgi?id=311637

Reviewed by Nikolas Zimmermann.

We create the SkSurface for tile buffers with an external texture
created with BitmapTexture, but MSAA doesn't work for surfaces created
from an external texture.

* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedTileBuffer.cpp:
(WebCore::CoordinatedAcceleratedTileBuffer::tryEnsureSurface):

Canonical link: https://commits.webkit.org/311059@main
@webkit-commit-queue webkit-commit-queue force-pushed the wpe-skia-no-msaa-tile-buffers branch from 2363fe6 to bdc29c5 Compare April 13, 2026 09:27
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 311059@main (bdc29c5): https://commits.webkit.org/311059@main

Reviewed commits have been landed. Closing PR #62185 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bdc29c5 into WebKit:main Apr 13, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 13, 2026
@carlosgcampos carlosgcampos deleted the wpe-skia-no-msaa-tile-buffers branch April 13, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants