base-select option hover style clipping with rotated transforms#62338
Draft
annevk wants to merge 1 commit intoWebKit:mainfrom
Draft
base-select option hover style clipping with rotated transforms#62338annevk wants to merge 1 commit intoWebKit:mainfrom
annevk wants to merge 1 commit intoWebKit:mainfrom
Conversation
https://bugs.webkit.org/show_bug.cgi?id=311402 rdar://171933742 Reviewed by NOBODY (OOPS!). In https://patrickbrosset.com/lab/custom-select/folders/ the options drawn outside the ::picker(select) rectangle have their :hover effect clipped by the rectangle. Strangely enough the cause of this is anchor positioning calling layout too often and invalidating all the time. (The hasRealAnchor change is only needed for picker-bug-no-select.html. The other changes are needed for picker-bug-minimal.html.)
Collaborator
|
EWS run on current version of this PR (hash 944721a) Details |
Collaborator
macOS Safer C++ Build #91680 (944721a)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
Collaborator
iOS Safer C++ Build #10630 (944721a)❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 ios-apple
944721a
944721a