Skip to content

base-select option hover style clipping with rotated transforms#62338

Draft
annevk wants to merge 1 commit intoWebKit:mainfrom
annevk:annevk/anchor-positioning-bug
Draft

base-select option hover style clipping with rotated transforms#62338
annevk wants to merge 1 commit intoWebKit:mainfrom
annevk:annevk/anchor-positioning-bug

Conversation

@annevk
Copy link
Copy Markdown
Contributor

@annevk annevk commented Apr 9, 2026

944721a

base-select option hover style clipping with rotated transforms
https://bugs.webkit.org/show_bug.cgi?id=311402
rdar://171933742

Reviewed by NOBODY (OOPS!).

In https://patrickbrosset.com/lab/custom-select/folders/ the options
drawn outside the ::picker(select) rectangle have their :hover effect
clipped by the rectangle.

Strangely enough the cause of this is anchor positioning calling layout
too often and invalidating all the time.

(The hasRealAnchor change is only needed for picker-bug-no-select.html.
The other changes are needed for picker-bug-minimal.html.)

944721a

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
❌ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
❌ 🛠 ios-safer-cpp ❌ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
✅ 🛠 tv ❌ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=311402
rdar://171933742

Reviewed by NOBODY (OOPS!).

In https://patrickbrosset.com/lab/custom-select/folders/ the options
drawn outside the ::picker(select) rectangle have their :hover effect
clipped by the rectangle.

Strangely enough the cause of this is anchor positioning calling layout
too often and invalidating all the time.

(The hasRealAnchor change is only needed for picker-bug-no-select.html.
The other changes are needed for picker-bug-minimal.html.)
@annevk annevk self-assigned this Apr 9, 2026
@annevk annevk added the Layout and Rendering For bugs with layout and rendering of Web pages. label Apr 9, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 9, 2026
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

macOS Safer C++ Build #91680 (944721a)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

iOS Safer C++ Build #10630 (944721a)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Layout and Rendering For bugs with layout and rendering of Web pages. merging-blocked Applied to prevent a change from being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants