Skip to content

Fix (more) some correctness issues for a few TestWebKitAPI tests#62424

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rr-codes:eng/Fix-more-some-correctness-issues-for-a-few-TestWebKitAPI-tests
Apr 10, 2026
Merged

Fix (more) some correctness issues for a few TestWebKitAPI tests#62424
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rr-codes:eng/Fix-more-some-correctness-issues-for-a-few-TestWebKitAPI-tests

Conversation

@rr-codes
Copy link
Copy Markdown
Contributor

@rr-codes rr-codes commented Apr 10, 2026

acd3aed

Fix (more) some correctness issues for a few TestWebKitAPI tests
https://bugs.webkit.org/show_bug.cgi?id=311909
rdar://174473169

Reviewed by Megan Gardner and Tim Horton.

Use RetainPtr instead of a raw pointer.

* Tools/TestWebKitAPI/Helpers/cocoa/TestWKWebView.mm:
(-[TestMessageHandler addMessage:withHandler:]):
(-[TestMessageHandler userContentController:didReceiveScriptMessage:]):

Canonical link: https://commits.webkit.org/310947@main

d2485e5

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win loading 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim loading 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rr-codes rr-codes self-assigned this Apr 10, 2026
@rr-codes rr-codes added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Apr 10, 2026
@rr-codes rr-codes force-pushed the eng/Fix-more-some-correctness-issues-for-a-few-TestWebKitAPI-tests branch from 18dbf19 to d2485e5 Compare April 10, 2026 07:21
@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label Apr 10, 2026
https://bugs.webkit.org/show_bug.cgi?id=311909
rdar://174473169

Reviewed by Megan Gardner and Tim Horton.

Use RetainPtr instead of a raw pointer.

* Tools/TestWebKitAPI/Helpers/cocoa/TestWKWebView.mm:
(-[TestMessageHandler addMessage:withHandler:]):
(-[TestMessageHandler userContentController:didReceiveScriptMessage:]):

Canonical link: https://commits.webkit.org/310947@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-more-some-correctness-issues-for-a-few-TestWebKitAPI-tests branch from d2485e5 to acd3aed Compare April 10, 2026 17:31
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 310947@main (acd3aed): https://commits.webkit.org/310947@main

Reviewed commits have been landed. Closing PR #62424 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit acd3aed into WebKit:main Apr 10, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants