Fix (more) some correctness issues for a few TestWebKitAPI tests#62424
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 10, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 18dbf19) Details
|
18dbf19 to
d2485e5
Compare
Collaborator
|
EWS run on current version of this PR (hash d2485e5) Details
|
megangardner
approved these changes
Apr 10, 2026
hortont424
approved these changes
Apr 10, 2026
https://bugs.webkit.org/show_bug.cgi?id=311909 rdar://174473169 Reviewed by Megan Gardner and Tim Horton. Use RetainPtr instead of a raw pointer. * Tools/TestWebKitAPI/Helpers/cocoa/TestWKWebView.mm: (-[TestMessageHandler addMessage:withHandler:]): (-[TestMessageHandler userContentController:didReceiveScriptMessage:]): Canonical link: https://commits.webkit.org/310947@main
d2485e5 to
acd3aed
Compare
Collaborator
|
Committed 310947@main (acd3aed): https://commits.webkit.org/310947@main Reviewed commits have been landed. Closing PR #62424 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 ios-apple
acd3aed
d2485e5
🛠 win🧪 win-tests