Find QuickPrivate component for WPE Qt API

[tusooa]

6998260

Find QuickPrivate component for WPE Qt API

https://bugs.webkit.org/show_bug.cgi?id=312064

Reviewed by Claudio Saavedra.

In newer versions of Qt6, Qt6Quick module no longer includes
the Qt6QuickPrivate, so we need to manually find the Qt6QuickPrivate
module. Compatibility kept for older versions by only requesting to
find Qt6QuickPrivate when the Qt::QuickPrivate is not yet available by
just finding Qt6Quick.

Configure-time only change, no runtime tests needed.

* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/311087@main

f4b51a9

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios		✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64		✅ 🧪 mac-wk2	🧪 gtk-wk2
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 1398c49)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios		✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64		✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[csaavedra]

It looks like the WebKit SDK doesn't have that package installed. You'll need to fix that too separately before we can land this.

That being said, why is this needed? If the SDK doesn't have the private package and it builds, I don't understand why this dependence is needed. But I'm not familiar with Qt at all, so I would appreciate your insight.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 71051ab)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios		✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64		✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🛠 playstation
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[tusooa]

It looks like the WebKit SDK doesn't have that package installed. You'll need to fix that too separately before we can land this.

That being said, why is this needed? If the SDK doesn't have the private package and it builds, I don't understand why this dependence is needed. But I'm not familiar with Qt at all, so I would appreciate your insight.

I changed the relevant configure code to find Qt6QuickPrivate only when Qt6Quick module does not provide the target Qt::QuickPrivate.

[csaavedra]

Can we make this version dependant instead or at least document in the comment since which version this is needed? This way we can remove the check once we start depending on a newer version.

[webkit-early-warning-system]

EWS run on current version of this PR (hash f4b51a9)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 api-mac-debug	✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc	✅ 🧪 api-ios		✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64		✅ 🧪 mac-wk2	🧪 gtk-wk2
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		✅ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[tusooa]

It looks like the WebKit SDK doesn't have that package installed. You'll need to fix that too separately before we can land this.

That being said, why is this needed? If the SDK doesn't have the private package and it builds, I don't understand why this dependence is needed. But I'm not familiar with Qt at all, so I would appreciate your insight.

I changed the relevant configure code to find Qt6QuickPrivate only when Qt6Quick module does not provide the target Qt::QuickPrivate.

Can we make this version dependant instead or at least document in the comment since which version this is needed? This way we can remove the check once we start depending on a newer version.

Yes, after investigating, this change is introduced in Qt 6.9.

[webkit-commit-queue]

Committed 311087@main (6998260): https://commits.webkit.org/311087@main

Reviewed commits have been landed. Closing PR #62564 and removing active labels.

[aperezdc]

Backported into webkitglib/2.52 as commit 06b34b9

(...and included in the 2.52.2 release, published a few minutes ago)