Skip to content

Fix remaining <img sizes=auto> failures#62630

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Fix-remaining-img-sizes-auto-failures
Apr 13, 2026
Merged

Fix remaining <img sizes=auto> failures#62630
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
annevk:eng/Fix-remaining-img-sizes-auto-failures

Conversation

@annevk
Copy link
Copy Markdown
Contributor

@annevk annevk commented Apr 13, 2026 •
edited by webkit-early-warning-system
Loading

7994a13

Fix remaining <img sizes=auto> failures
https://bugs.webkit.org/show_bug.cgi?id=312145

Reviewed by Tim Nguyen.

Fix the remaining issue and update stale test expectations.

Canonical link: https://commits.webkit.org/311138@main

9279d2c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Apr 13, 2026
@annevk annevk requested review from cdumez and rniwa as code owners April 13, 2026 11:43
@annevk annevk added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 13, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 13, 2026 •
edited
Loading

EWS run on previous version of this PR (hash a6a66c4)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🛠 playstation
  🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk force-pushed the eng/Fix-remaining-img-sizes-auto-failures branch from a6a66c4 to 9279d2c Compare April 13, 2026 11:49
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 13, 2026 •
edited
Loading

EWS run on current version of this PR (hash 9279d2c)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@yoavweiss yoavweiss self-requested a review April 13, 2026 11:54
yoavweiss
yoavweiss approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for tackling this!!

@annevk annevk added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 13, 2026
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Apr 13, 2026
@webkit-ews-buildbot
Copy link
Copy Markdown
Collaborator

webkit-ews-buildbot commented Apr 13, 2026

Safe-Merge-Queue: Build #89512.

@annevk
Fix remaining <img sizes=auto> failures
7994a13 
https://bugs.webkit.org/show_bug.cgi?id=312145

Reviewed by Tim Nguyen.

Fix the remaining issue and update stale test expectations.

Canonical link: https://commits.webkit.org/311138@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-remaining-img-sizes-auto-failures branch from 9279d2c to 7994a13 Compare April 13, 2026 20:40
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Apr 13, 2026

Committed 311138@main (7994a13): https://commits.webkit.org/311138@main

Reviewed commits have been landed. Closing PR #62630 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7994a13 into WebKit:main Apr 13, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 13, 2026
@annevk annevk deleted the eng/Fix-remaining-img-sizes-auto-failures branch April 13, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

@nt1m nt1m nt1m approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@annevk annevk

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@annevk @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @yoavweiss @nt1m