[Scroll anchoring] Transform changes fail to suppress anchoring sometimes#62741
Merged
webkit-commit-queue merged 1 commit intoApr 15, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 7c45108) Details
|
alanbaradlay
approved these changes
Apr 14, 2026
7c45108 to
1bfcf26
Compare
Collaborator
|
EWS run on current version of this PR (hash 1bfcf26) Details
|
…imes https://bugs.webkit.org/show_bug.cgi?id=312277 rdar://174503821 Reviewed by Alan Baradlay. A transform change results in a `Style::DifferenceResult::Overflow` or `RecompositeLayer`, so we need to all `scrollAnchoringSuppressionStyleDidChange()` for this diff type. The test needs to change both height of a sibling, and transform on the wrapper, because the transform change alone never results in anchoring adjustments; this is because the before-layout transform already has the new state, since RenderLayer updates its transform on style change. But this isn't a problem, since transform changes suppress anchoring anyway. Test: imported/w3c/web-platform-tests/css/css-scroll-anchoring/suppress-for-transform-change.html * LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/suppress-for-transform-change-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/suppress-for-transform-change.html: Added. * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::styleDidChange): Canonical link: https://commits.webkit.org/311253@main
1bfcf26 to
71619b4
Compare
Collaborator
|
Committed 311253@main (71619b4): https://commits.webkit.org/311253@main Reviewed commits have been landed. Closing PR #62741 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
71619b4
1bfcf26
🛠 win🧪 win-tests