Skip to content

Simplify incrementing WTF::HashMap counts by dropping redundant isNewEntry check in WebCore#62785

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
iidmsa:eng/Simplify-incrementing-counts-by-dropping-redundant-isNewEntry-check-in-WebCore
Apr 16, 2026
Merged

Simplify incrementing WTF::HashMap counts by dropping redundant isNewEntry check in WebCore#62785
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
iidmsa:eng/Simplify-incrementing-counts-by-dropping-redundant-isNewEntry-check-in-WebCore

Conversation

@iidmsa
Copy link
Copy Markdown
Member

@iidmsa iidmsa commented Apr 15, 2026 •
edited by webkit-early-warning-system
Loading

3645b67

Simplify incrementing WTF::HashMap counts by dropping redundant isNewEntry check in WebCore
https://bugs.webkit.org/show_bug.cgi?id=312334
rdar://174790523

Reviewed by Fujii Hironori.

* Source/WebCore/dom/Node.cpp:
(WebCore::Node::dumpStatistics):

Canonical link: https://commits.webkit.org/311358@main

02bda6e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iidmsa iidmsa requested a review from rniwa as a code owner April 15, 2026 00:45
@iidmsa iidmsa self-assigned this Apr 15, 2026
@iidmsa iidmsa requested a review from cdumez as a code owner April 15, 2026 00:45
@iidmsa iidmsa added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 15, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 15, 2026 •
edited
Loading

EWS run on previous version of this PR (hash a6fb880)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
  🛠 ios-safer-cpp   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@iidmsa iidmsa requested a review from darinadler April 15, 2026 00:57
@iidmsa iidmsa changed the title Simplify incrementing counts by dropping redundant isNewEntry check in WebCore Simplify incrementing WTF::HashMap counts by dropping redundant isNewEntry check in WebCore Apr 15, 2026
@iidmsa iidmsa force-pushed the eng/Simplify-incrementing-counts-by-dropping-redundant-isNewEntry-check-in-WebCore branch from a6fb880 to 02bda6e Compare April 15, 2026 01:02
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 15, 2026 •
edited
Loading

EWS run on current version of this PR (hash 02bda6e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iidmsa iidmsa requested a review from weinig April 15, 2026 13:42
@iidmsa iidmsa added the merge-queue Applied to send a pull request to merge-queue label Apr 16, 2026
@iidmsa
Simplify incrementing WTF::HashMap counts by dropping redundant isNew…
3645b67 
…Entry check in WebCore

https://bugs.webkit.org/show_bug.cgi?id=312334
rdar://174790523

Reviewed by Fujii Hironori.

* Source/WebCore/dom/Node.cpp:
(WebCore::Node::dumpStatistics):

Canonical link: https://commits.webkit.org/311358@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Simplify-incrementing-counts-by-dropping-redundant-isNewEntry-check-in-WebCore branch from 02bda6e to 3645b67 Compare April 16, 2026 10:41
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Apr 16, 2026

Committed 311358@main (3645b67): https://commits.webkit.org/311358@main

Reviewed commits have been landed. Closing PR #62785 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3645b67 into WebKit:main Apr 16, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 16, 2026
@iidmsa iidmsa deleted the eng/Simplify-incrementing-counts-by-dropping-redundant-isNewEntry-check-in-WebCore branch April 17, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujii fujii fujii approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@darinadler darinadler Awaiting requested review from darinadler

@weinig weinig Awaiting requested review from weinig

Assignees

@iidmsa iidmsa

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iidmsa @webkit-early-warning-system @webkit-commit-queue @fujii