Skip to content

REGRESSION (r278062): Multiple backgrounds with "background-blend-mode: difference" breaks #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 1 commit into from
Nov 11, 2022
Merged

REGRESSION (r278062): Multiple backgrounds with "background-blend-mode: difference" breaks #6280

webkit-early-warning-system merged 1 commit into from
Nov 11, 2022

Conversation

@shallawa
Copy link
Contributor

@shallawa shallawa commented Nov 9, 2022 •
edited by webkit-early-warning-system
Loading

9ffcb90

REGRESSION (r278062): Multiple backgrounds with "background-blend-mode: difference" breaks
https://bugs.webkit.org/show_bug.cgi?id=246590
rdar://101257606

Reviewed by Tim Horton.

r278062 replaced the call to GraphicsContextCG::setPlatformCompositeOperation()
by GraphicsContext::setCompositeOperation() in GraphicsContextCG::drawPattern().
setCompositeOperation() is platform independent and should not be called from
GraphicsContextCG methods. Call GraphicsContextCG::setCGBlendMode() instead.

* LayoutTests/fast/backgrounds/background-blend-mode-difference-expected.html: Added.
* LayoutTests/fast/backgrounds/background-blend-mode-difference.html: Added.
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::drawPattern):

Canonical link: https://commits.webkit.org/256578@main

486a2f2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ❌ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
  🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@shallawa shallawa self-assigned this Nov 9, 2022
@shallawa shallawa added the Layout and Rendering For bugs with layout and rendering of Web pages. label Nov 9, 2022
@shallawa shallawa requested a review from hortont424 November 9, 2022 01:33
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 9, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 34475d4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@shallawa shallawa removed the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022
@shallawa shallawa force-pushed the eng/REGRESSION-r278062-Multiple-backgrounds-with-background-blend-mode-difference-breaks branch from 34475d4 to 994d591 Compare November 9, 2022 19:25
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 9, 2022 •
edited
Loading

EWS run on previous version of this PR (hash 994d591)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022
@shallawa shallawa removed the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022
@shallawa shallawa force-pushed the eng/REGRESSION-r278062-Multiple-backgrounds-with-background-blend-mode-difference-breaks branch from 994d591 to 486a2f2 Compare November 10, 2022 17:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 10, 2022 •
edited
Loading

EWS run on current version of this PR (hash 486a2f2)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ❌ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
  🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022
@shallawa shallawa added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Nov 11, 2022
@shallawa
REGRESSION (r278062): Multiple backgrounds with "background-blend-mod…
9ffcb90 
…e: difference" breaks

https://bugs.webkit.org/show_bug.cgi?id=246590
rdar://101257606

Reviewed by Tim Horton.

r278062 replaced the call to GraphicsContextCG::setPlatformCompositeOperation()
by GraphicsContext::setCompositeOperation() in GraphicsContextCG::drawPattern().
setCompositeOperation() is platform independent and should not be called from
GraphicsContextCG methods. Call GraphicsContextCG::setCGBlendMode() instead.

* LayoutTests/fast/backgrounds/background-blend-mode-difference-expected.html: Added.
* LayoutTests/fast/backgrounds/background-blend-mode-difference.html: Added.
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::drawPattern):

Canonical link: https://commits.webkit.org/256578@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-r278062-Multiple-backgrounds-with-background-blend-mode-difference-breaks branch from 486a2f2 to 9ffcb90 Compare November 11, 2022 18:48
@webkit-early-warning-system webkit-early-warning-system merged commit 9ffcb90 into WebKit:main Nov 11, 2022
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Nov 11, 2022

Committed 256578@main (9ffcb90): https://commits.webkit.org/256578@main

Reviewed commits have been landed. Closing PR #6280 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Nov 11, 2022
@shallawa shallawa deleted the eng/REGRESSION-r278062-Multiple-backgrounds-with-background-blend-mode-difference-breaks branch May 9, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hortont424 hortont424 hortont424 approved these changes

Assignees

@shallawa shallawa

Labels

Layout and Rendering For bugs with layout and rendering of Web pages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shallawa @webkit-early-warning-system @webkit-commit-queue @hortont424 @webkit-ews-buildbot