[WebXR Layers] Use the correct GraphicsContextGLExternalImageSource for Android#62802
Merged
webkit-commit-queue merged 1 commit intoApr 15, 2026
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 44442df) Details |
aperezdc
approved these changes
Apr 15, 2026
…or Android https://bugs.webkit.org/show_bug.cgi?id=312356 Reviewed by Adrian Perez de Castro. Android platform does not provide DMABuf for sharing textures. Instead AndroidHardwareBuffer is the native solution for that use case. We were not properly handling that in the WebGL swapchains used in WebXR layers code resulting in build failures in Android. The very same solution is used in the WebXR opaque framebuffer used for regular (non-layers) WebXR content. No need for new tests as this is fixing the build in Android. * Source/WebCore/Modules/webxr/WebXRWebGLSwapchain.cpp: (WebCore::makeExternalImageSource): Canonical link: https://commits.webkit.org/311286@main
44442df to
75ad096
Compare
Collaborator
|
Committed 311286@main (75ad096): https://commits.webkit.org/311286@main Reviewed commits have been landed. Closing PR #62802 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
75ad096
44442df
🛠 win🧪 win-tests🧪 api-mac🧪 ios-wk2-wpt