Skip to content

[WebXR Layers] Use the correct GraphicsContextGLExternalImageSource for Android#62802

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
svillar:android_layers_swapchain
Apr 15, 2026
Merged

[WebXR Layers] Use the correct GraphicsContextGLExternalImageSource for Android#62802
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
svillar:android_layers_swapchain

Conversation

@svillar
Copy link
Copy Markdown
Contributor

@svillar svillar commented Apr 15, 2026

75ad096

[WebXR Layers] Use the correct GraphicsContextGLExternalImageSource for Android
https://bugs.webkit.org/show_bug.cgi?id=312356

Reviewed by Adrian Perez de Castro.

Android platform does not provide DMABuf for sharing textures. Instead
AndroidHardwareBuffer is the native solution for that use case. We were
not properly handling that in the WebGL swapchains used in WebXR layers
code resulting in build failures in Android.

The very same solution is used in the WebXR opaque framebuffer used for
regular (non-layers) WebXR content.

No need for new tests as this is fixing the build in Android.

* Source/WebCore/Modules/webxr/WebXRWebGLSwapchain.cpp:
(WebCore::makeExternalImageSource):

Canonical link: https://commits.webkit.org/311286@main

44442df

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@svillar svillar self-assigned this Apr 15, 2026
@svillar svillar added the WebXR For bugs in WebXR label Apr 15, 2026
@svillar svillar added the merge-queue Applied to send a pull request to merge-queue label Apr 15, 2026
…or Android

https://bugs.webkit.org/show_bug.cgi?id=312356

Reviewed by Adrian Perez de Castro.

Android platform does not provide DMABuf for sharing textures. Instead
AndroidHardwareBuffer is the native solution for that use case. We were
not properly handling that in the WebGL swapchains used in WebXR layers
code resulting in build failures in Android.

The very same solution is used in the WebXR opaque framebuffer used for
regular (non-layers) WebXR content.

No need for new tests as this is fixing the build in Android.

* Source/WebCore/Modules/webxr/WebXRWebGLSwapchain.cpp:
(WebCore::makeExternalImageSource):

Canonical link: https://commits.webkit.org/311286@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 311286@main (75ad096): https://commits.webkit.org/311286@main

Reviewed commits have been landed. Closing PR #62802 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 75ad096 into WebKit:main Apr 15, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebXR For bugs in WebXR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants