Migrate away from UIApplication.sharedApplication.statusBarFrame in WebKitTestRunner#62870
Merged
Conversation
smfr
added
the
Tools / Tests
Collaborator
|
EWS run on previous version of this PR (hash e2bd3db) Details
|
pxlcoder
approved these changes
Apr 16, 2026
| // We add the status bar in here because it is subtracted back out in viewRectForWindowRect. | ||
| static constexpr CGSize defaultTestingiPadViewSize = { 810, 1060 }; | ||
| sceneBounds = CGRectMake(0, 0, defaultTestingiPadViewSize.width, defaultTestingiPadViewSize.height + CGRectGetHeight(UIApplication.sharedApplication.statusBarFrame)); | ||
| auto *scene = webView.window.windowScene; |
Member
There was a problem hiding this comment.
We already have scene on line 490.
Suggested change
| auto *scene = webView.window.windowScene; |
smfr
force-pushed
the
eng/Migrate-away-from-UIApplication-sharedApplication-statusBarFrame-in-WebKitTestRunner
branch
from
e2bd3db to
7f76cc7
Compare
Collaborator
|
EWS run on current version of this PR (hash 7f76cc7) Details
|
🛠 vision
…ebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=312432 rdar://174655309 Reviewed by Aditya Keerthi and Abrar Rahman Protyasha. `UIApplication.sharedApplication.statusBarFrame` has been deprecated for a while, so move to UIScene-based status bar API. * Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::viewRectForWindowRect): * Tools/WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::platformConfigureViewForTest): Canonical link: https://commits.webkit.org/311370@main
webkit-commit-queue
force-pushed
the
eng/Migrate-away-from-UIApplication-sharedApplication-statusBarFrame-in-WebKitTestRunner
branch
from
7f76cc7 to
5a8ae3a
Compare
Collaborator
|
Committed 311370@main (5a8ae3a): https://commits.webkit.org/311370@main Reviewed commits have been landed. Closing PR #62870 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5a8ae3a
7f76cc7