Skip to content

[OpenXR] Improve cmake detection#62904

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
svillar:openxr_detection
Apr 20, 2026
Merged

[OpenXR] Improve cmake detection#62904
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
svillar:openxr_detection

Conversation

@svillar
Copy link
Copy Markdown
Contributor

@svillar svillar commented Apr 16, 2026

3417f57

[OpenXR] Improve cmake detection
https://bugs.webkit.org/show_bug.cgi?id=312486

Reviewed by Adrian Perez de Castro.

This commit addresses 3 different issues:
- Do not require a minimum version (we properly guard code)
- Do not abort if not found, we can just require it and we'll get that
  for free. Actually the check was wrong (OPENXR_FOUND was invalid, it
  should be OpenXR_FOUND).
- Use config-only package mode. We shouldn't ever need a
  FindOpenXR.cmake file, otherwise something else is wrong.

No new tests as we're modifying build options

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/311566@main

98981db

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@svillar svillar requested a review from a team as a code owner April 16, 2026 17:22
@svillar svillar self-assigned this Apr 16, 2026
@svillar svillar added the WebXR For bugs in WebXR label Apr 16, 2026
@svillar svillar requested a review from aperezdc April 16, 2026 17:24
@svillar svillar added the merge-queue Applied to send a pull request to merge-queue label Apr 20, 2026
https://bugs.webkit.org/show_bug.cgi?id=312486

Reviewed by Adrian Perez de Castro.

This commit addresses 3 different issues:
- Do not require a minimum version (we properly guard code)
- Do not abort if not found, we can just require it and we'll get that
  for free. Actually the check was wrong (OPENXR_FOUND was invalid, it
  should be OpenXR_FOUND).
- Use config-only package mode. We shouldn't ever need a
  FindOpenXR.cmake file, otherwise something else is wrong.

No new tests as we're modifying build options

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/311566@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 311566@main (3417f57): https://commits.webkit.org/311566@main

Reviewed commits have been landed. Closing PR #62904 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3417f57 into WebKit:main Apr 20, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebXR For bugs in WebXR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants