[OpenXR] Improve cmake detection#62904
Merged
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 98981db) Details |
aperezdc
approved these changes
Apr 20, 2026
https://bugs.webkit.org/show_bug.cgi?id=312486 Reviewed by Adrian Perez de Castro. This commit addresses 3 different issues: - Do not require a minimum version (we properly guard code) - Do not abort if not found, we can just require it and we'll get that for free. Actually the check was wrong (OPENXR_FOUND was invalid, it should be OpenXR_FOUND). - Use config-only package mode. We shouldn't ever need a FindOpenXR.cmake file, otherwise something else is wrong. No new tests as we're modifying build options * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/311566@main
98981db to
3417f57
Compare
Collaborator
|
Committed 311566@main (3417f57): https://commits.webkit.org/311566@main Reviewed commits have been landed. Closing PR #62904 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3417f57
98981db