Skip to content

[GPUP] Improve worker thread assertions in RemoteRenderingBackend#62922

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
zakariaridouh:eng/GPUP-Improve-worker-thread-assertions-in-RemoteRenderingBackend
Apr 18, 2026
Merged

[GPUP] Improve worker thread assertions in RemoteRenderingBackend#62922
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
zakariaridouh:eng/GPUP-Improve-worker-thread-assertions-in-RemoteRenderingBackend

Conversation

@zakariaridouh
Copy link
Copy Markdown
Contributor

@zakariaridouh zakariaridouh commented Apr 16, 2026

5eb98d5

[GPUP] Improve worker thread assertions in RemoteRenderingBackend
https://bugs.webkit.org/show_bug.cgi?id=312510
rdar://174950627

Reviewed by Vitor Roriz.

Replace ASSERT(!RunLoop::isMain()) with assertIsCurrent(workQueue()) in
RemoteRenderingBackend cache methods and releaseMemory, matching the
stricter assertion already used in the filter caching path since 309995@main

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheNativeImage):
(WebKit::RemoteRenderingBackend::cacheFont):
(WebKit::RemoteRenderingBackend::cacheFontCustomPlatformData):
(WebKit::RemoteRenderingBackend::releaseMemory):

Canonical link: https://commits.webkit.org/311529@main

95247dd

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ⏳ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ⏳ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh zakariaridouh self-assigned this Apr 16, 2026
@zakariaridouh zakariaridouh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 16, 2026
@zakariaridouh zakariaridouh added the merge-queue Applied to send a pull request to merge-queue label Apr 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=312510
rdar://174950627

Reviewed by Vitor Roriz.

Replace ASSERT(!RunLoop::isMain()) with assertIsCurrent(workQueue()) in
RemoteRenderingBackend cache methods and releaseMemory, matching the
stricter assertion already used in the filter caching path since 309995@main

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheNativeImage):
(WebKit::RemoteRenderingBackend::cacheFont):
(WebKit::RemoteRenderingBackend::cacheFontCustomPlatformData):
(WebKit::RemoteRenderingBackend::releaseMemory):

Canonical link: https://commits.webkit.org/311529@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GPUP-Improve-worker-thread-assertions-in-RemoteRenderingBackend branch from 95247dd to 5eb98d5 Compare April 18, 2026 15:53
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 311529@main (5eb98d5): https://commits.webkit.org/311529@main

Reviewed commits have been landed. Closing PR #62922 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5eb98d5 into WebKit:main Apr 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants