REGRESSION(308531@main): [GStreamer][1.28] Flaky crashes when running test fast/mediastream/error.html#63066
Merged
Merged
Conversation
philn
added
the
New Bugs
Collaborator
|
EWS run on previous version of this PR (hash d25e752) Details |
philn
added
the
GLib Suggested Backport - 2.52
calvaris
approved these changes
Apr 20, 2026
Contributor
calvaris
left a comment
calvaris
left a comment
There was a problem hiding this comment.
in the changelog, I think, attach -> attaches
Collaborator
|
EWS run on current version of this PR (hash cb32618) Details |
… test fast/mediastream/error.html https://bugs.webkit.org/show_bug.cgi?id=312157 Reviewed by Xabier Rodriguez-Calvar. Calling gst_bus_poll() creates a new GSource and attaches it to the thread default GMainContext, which introduced re-entrancy, where the GSource would wake-up the WebProcess main loop, make it process an IPC message that would lead to a capture devices reset and a crash. Use gst_bus_timed_pop_filtered() instead, which doesn't have this issue. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp: (WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices): Canonical link: https://commits.webkit.org/311567@main
webkit-commit-queue
force-pushed
the
eng/312157
branch
from
cb32618 to
ab66525
Compare
Collaborator
|
Committed 311567@main (ab66525): https://commits.webkit.org/311567@main Reviewed commits have been landed. Closing PR #63066 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Contributor
|
Backported into |
aperezdc
removed
the
GLib Suggested Backport - 2.52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ab66525
cb32618
🛠 mac🛠 wpe🛠 win🧪 wpe-wk2🧪 win-tests🧪 api-mac🧪 api-wpe🧪 api-mac-debug🛠 gtk3-libwebrtc🧪 mac-wk1🧪 mac-wk2🧪 gtk-wk2🧪 api-gtk🧪 mac-wk2-stress🧪 vision-wk2🧪 mac-intel-wk2🛠 mac-safer-cpp