AX: Clean up ref handling in AccessibilityObjectAtspi::focus()#63075
Merged
webkit-commit-queue merged 1 commit intoApr 19, 2026
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 5f20c24) Details |
csaavedra
requested changes
Apr 19, 2026
Comment on lines
+152
to
+154
| coreObject.get().setFocused(true); | ||
| coreObject.get().updateBackingStore(); | ||
| return coreObject.get().isFocused(); |
Member
There was a problem hiding this comment.
Suggested change
| coreObject.get().setFocused(true); | |
| coreObject.get().updateBackingStore(); | |
| return coreObject.get().isFocused(); | |
| coreObject->setFocused(true); | |
| coreObject->updateBackingStore(); | |
| return coreObject->isFocused(); |
mgorse
force-pushed
the
eng/AX-Clean-up-ref-handling-in-AccessibilityObjectAtspi-focus
branch
from
5f20c24 to
e35e56f
Compare
Collaborator
|
EWS run on current version of this PR (hash e35e56f) Details |
csaavedra
approved these changes
Apr 19, 2026
https://bugs.webkit.org/show_bug.cgi?id=312725 Reviewed by Claudio Saavedra. There is already a check that m_coreObject is not nullptr, so this can be a Ref. * Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp: (WebCore::AccessibilityObjectAtspi::focus const): Canonical link: https://commits.webkit.org/311544@main
webkit-commit-queue
force-pushed
the
eng/AX-Clean-up-ref-handling-in-AccessibilityObjectAtspi-focus
branch
from
e35e56f to
fc2dea6
Compare
Collaborator
|
Committed 311544@main (fc2dea6): https://commits.webkit.org/311544@main Reviewed commits have been landed. Closing PR #63075 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
aperezdc
added
the
GLib Suggested Backport - 2.52
Contributor
|
Backported into |
aperezdc
removed
the
GLib Suggested Backport - 2.52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fc2dea6
e35e56f
🧪 api-mac-debug🧪 mac-AS-debug-wk2