[GTK3] Fix build#63108
Conversation
|
EWS run on previous version of this PR (hash 4a3fb94) Details |
4a3fb94 to
001809b
Compare
|
EWS run on current version of this PR (hash 001809b) Details |
https://bugs.webkit.org/show_bug.cgi?id=312764 Unreviewed build fix. * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp: Canonical link: https://commits.webkit.org/311574@main
001809b to
9e50dcb
Compare
|
Committed 311574@main (9e50dcb): https://commits.webkit.org/311574@main Reviewed commits have been landed. Closing PR #63108 and removing active labels. |
| #include <WebCore/Document.h> | ||
| #include "GObjectEventListener.h" | ||
| #include <JavaScriptCore/APICast.h> | ||
| #include <JavaScriptCore/JSCellInlines.h> |
There was a problem hiding this comment.
@jernoble I had to add this include here even when this file doesn't use any method defined in that header because of the use of toJS() below. APICast.h has an inlined function toJS() that calls JSCell::methodTable(), so any use of toJS() ends up depending on JSCellInlines.h indirectly.
One shouldn't add JSCellInlines.h to APICast.h tho as it's not a good idea to add such headers includes to another header file; also this method probably needs to be inlined so one can't hide the definition inside a .cpp file.
Sharing this with you as you continue to work on this area and splitting down large headers (thank you!), to keep these issues in mind.
🛠 watch
9e50dcb
001809b
🛠 mac🛠 wpe🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 api-mac-debug🛠 gtk3-libwebrtc🧪 api-ios🛠 gtk🧪 mac-wk2🧪 gtk-wk2🛠 vision🧪 mac-AS-debug-wk2🧪 api-gtk🛠 vision-sim🧪 mac-wk2-stress🛠 playstation🧪 vision-wk2🧪 mac-intel-wk2🛠 tv🛠 tv-sim🛠 watch-sim