Skip to content

[GTK3] Fix build#63108

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
csaavedra:eng/GTK3-Fix-build
Apr 20, 2026
Merged

[GTK3] Fix build#63108
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
csaavedra:eng/GTK3-Fix-build

Conversation

@csaavedra csaavedra requested a review from a team as a code owner April 20, 2026 10:53
@csaavedra csaavedra self-assigned this Apr 20, 2026
@csaavedra csaavedra added the WebKitGTK Bugs related to the Gtk API layer. label Apr 20, 2026
@csaavedra csaavedra force-pushed the eng/GTK3-Fix-build branch from 4a3fb94 to 001809b Compare April 20, 2026 10:54
@csaavedra csaavedra added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 20, 2026
https://bugs.webkit.org/show_bug.cgi?id=312764

Unreviewed build fix.

* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp:

Canonical link: https://commits.webkit.org/311574@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 311574@main (9e50dcb): https://commits.webkit.org/311574@main

Reviewed commits have been landed. Closing PR #63108 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9e50dcb into WebKit:main Apr 20, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 20, 2026
#include <WebCore/Document.h>
#include "GObjectEventListener.h"
#include <JavaScriptCore/APICast.h>
#include <JavaScriptCore/JSCellInlines.h>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jernoble I had to add this include here even when this file doesn't use any method defined in that header because of the use of toJS() below. APICast.h has an inlined function toJS() that calls JSCell::methodTable(), so any use of toJS() ends up depending on JSCellInlines.h indirectly.

One shouldn't add JSCellInlines.h to APICast.h tho as it's not a good idea to add such headers includes to another header file; also this method probably needs to be inlined so one can't hide the definition inside a .cpp file.

Sharing this with you as you continue to work on this area and splitting down large headers (thank you!), to keep these issues in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants