ANGLE: Metal BufferDataTestES3.GLDriverErrorWhenMappingArrayBuffersDuringDraw fails validation#63120
Merged
webkit-commit-queue merged 1 commit intoApr 21, 2026
Conversation
Collaborator
|
EWS run on current version of this PR (hash 67d447e) Details |
djg
approved these changes
Apr 21, 2026
| @@ -1048,7 +1048,7 @@ TEST_P(BufferDataTestES3, GLDriverErrorWhenMappingArrayBuffersDuringDraw) | |||
|
|
|||
| GLBuffer vb; | |||
| glBindBuffer(GL_ARRAY_BUFFER, vb); | |||
| glBufferData(GL_ARRAY_BUFFER, sizeof(GLfloat) * quadVertices.size(), quadVertices.data(), | |||
| glBufferData(GL_ARRAY_BUFFER, sizeof(GLfloat) * quadVertices.size() * 3, quadVertices.data(), | |||
Contributor
There was a problem hiding this comment.
How about
glBufferData(GL_ARRAY_BUFFER, sizeof(quadVertices), quadVertices.data(), GL_STATIC_DRAW);
kkinnunen-apple
added
the
merge-queue
…ringDraw fails validation https://bugs.webkit.org/show_bug.cgi?id=312773 rdar://175158716 Reviewed by Dan Glastonbury. The test computed the vertex buffer size incorrectly. * Source/ThirdParty/ANGLE/src/tests/gl_tests/BufferDataTest.cpp: Canonical link: https://commits.webkit.org/311650@main
webkit-commit-queue
force-pushed
the
angle-GLDriverErrorWhenMappingArrayBuffersDuringDraw
branch
from
67d447e to
cda121a
Compare
Collaborator
|
Committed 311650@main (cda121a): https://commits.webkit.org/311650@main Reviewed commits have been landed. Closing PR #63120 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cda121a
67d447e
🧪 api-gtk