REGRESSION(306842@main): [WPE] Build with ENABLE_WPE_PLATFORM=OFF fails#63121
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 21, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 593bf23) Details |
593bf23 to
fcd3c33
Compare
Collaborator
|
EWS run on current version of this PR (hash fcd3c33) Details |
carlosgcampos
approved these changes
Apr 21, 2026
https://bugs.webkit.org/show_bug.cgi?id=312769 Reviewed by Carlos Garcia Campos. Avoid using the HardwareAccelerationEnabled preference when WPEPlatform is disabled, and make the AcceleratedSurface::usesGL() helper return a fixed value when ENABLE(WPE_PLATFORM) is disabled, because in that case accelerated compositing is always used. * Source/WebKit/UIProcess/API/wpe/WebKitWebViewBackend.cpp: Change order of includes to ensure that the USE() macro is defined before using it. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.cpp: (WebKit::AcceleratedSurface::AcceleratedSurface): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AcceleratedSurface.h: Canonical link: https://commits.webkit.org/311656@main
fcd3c33 to
dc1afde
Compare
Collaborator
|
Committed 311656@main (dc1afde): https://commits.webkit.org/311656@main Reviewed commits have been landed. Closing PR #63121 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dc1afde
fcd3c33