Skip to content

REGRESSION(311815@main): ASSERT in Document::addScreenPropertiesChangedObserver(), !m_screenPropertiesChangedObservers.contains(observer)#63437

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
jernoble:eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer
Apr 24, 2026
Merged

REGRESSION(311815@main): ASSERT in Document::addScreenPropertiesChangedObserver(), !m_screenPropertiesChangedObservers.contains(observer)#63437
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
jernoble:eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer

Conversation

@jernoble
Copy link
Copy Markdown
Contributor

@jernoble jernoble commented Apr 23, 2026 •
edited by webkit-early-warning-system
Loading

21d6c87

REGRESSION(311815@main): ASSERT in Document::addScreenPropertiesChangedObserver(), !m_screenPropertiesChangedObservers.contains(observer)
rdar://175436583
https://bugs.webkit.org/show_bug.cgi?id=313144

Reviewed by Andy Estes.

Ensure the ScreenPropertyChangedObserver is removed from the
HTMLMediaElement's document during unregisterWithDocument()
by making it a RefPtr and explicitly nulling it out, ensuring
the same observer is not added twice to the same document.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::m_remote):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/311910@main

5bb8872

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🛠 ios-safer-cpp ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@jernoble jernoble requested review from cdumez and rniwa as code owners April 23, 2026 17:09
@jernoble jernoble self-assigned this Apr 23, 2026
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Apr 23, 2026
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 23, 2026 •
edited
Loading

EWS run on previous version of this PR (hash afa7973)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style   🛠 ios ❌ 🛠 mac   🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings   🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2 ❌ 🧪 api-mac   🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug   🛠 gtk3-libwebrtc
  🧪 api-ios ❌ 🧪 mac-wk1   🛠 gtk
  🛠 ios-safer-cpp ❌ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision ❌ 🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 vision-sim ❌ 🧪 mac-wk2-stress   🛠 playstation
  🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@jernoble jernoble force-pushed the eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer branch from afa7973 to f9221f0 Compare April 23, 2026 17:21
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 23, 2026 •
edited
Loading

EWS run on previous version of this PR (hash f9221f0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe loading-orange 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 loading-orange 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe ⏳ 🛠 vision-apple
❌ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug ❌ 🛠 gtk3-libwebrtc
❌ 🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🛠 gtk
❌ 🛠 ios-safer-cpp ❌ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🛠 playstation
❌ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
❌ 🛠 tv ❌ 🛠 mac-safer-cpp
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 23, 2026
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label Apr 23, 2026
@jernoble jernoble force-pushed the eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer branch from f9221f0 to 74fb810 Compare April 23, 2026 22:13
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 23, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 74fb810)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe ⏳ 🛠 vision-apple
❌ 🧪 ios-wk2-wpt ❌ 🧪 api-mac-debug ❌ 🛠 gtk3-libwebrtc
❌ 🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🛠 gtk
  🛠 ios-safer-cpp ❌ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress   🛠 playstation
❌ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2
❌ 🛠 tv   🛠 mac-safer-cpp
❌ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 23, 2026
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label Apr 23, 2026
@jernoble jernoble force-pushed the eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer branch from 74fb810 to 5bb8872 Compare April 23, 2026 23:15
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Apr 23, 2026 •
edited
Loading

EWS run on current version of this PR (hash 5bb8872)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🛠 ios-safer-cpp ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2   🧪 mac-intel-wk2
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@jernoble jernoble added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 24, 2026
@jernoble
REGRESSION(311815@main): ASSERT in Document::addScreenPropertiesChang…
21d6c87 
…edObserver(), !m_screenPropertiesChangedObservers.contains(observer)

rdar://175436583
https://bugs.webkit.org/show_bug.cgi?id=313144

Reviewed by Andy Estes.

Ensure the ScreenPropertyChangedObserver is removed from the
HTMLMediaElement's document during unregisterWithDocument()
by making it a RefPtr and explicitly nulling it out, ensuring
the same observer is not added twice to the same document.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::m_remote):
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/311910@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer branch from 5bb8872 to 21d6c87 Compare April 24, 2026 00:36
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Apr 24, 2026

Committed 311910@main (21d6c87): https://commits.webkit.org/311910@main

Reviewed commits have been landed. Closing PR #63437 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 21d6c87 into WebKit:main Apr 24, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 24, 2026
@jernoble jernoble deleted the eng/REGRESSION-311815-main-ASSERT-in-Document-addScreenPropertiesChangedObserver-m_screenPropertiesChangedObservers-contains-observer branch April 29, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aestes aestes aestes approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@webkit-early-warning-system webkit-early-warning-system Awaiting requested review from webkit-early-warning-system

Assignees

@jernoble jernoble

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jernoble @webkit-early-warning-system @webkit-commit-queue @aestes @webkit-ews-buildbot