Skip to content

[JSC] Remove createSuppressedError builtin#63612

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/JSC-Remove-createSuppressedError-builtin
Apr 26, 2026
Merged

[JSC] Remove createSuppressedError builtin#63612
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/JSC-Remove-createSuppressedError-builtin

Conversation

@Constellation
Copy link
Copy Markdown
Member

@Constellation Constellation commented Apr 26, 2026

d1ec7b5

[JSC] Remove createSuppressedError builtin
https://bugs.webkit.org/show_bug.cgi?id=313331
rdar://175608137

Reviewed by Sosuke Suzuki.

It is just caling a SuppressedError constructor. We should just call it
directly.

* Source/JavaScriptCore/builtins/DisposableStackPrototype.js:
(linkTimeConstant.createSuppressedError): Deleted.
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitUsingBodyScope):

Canonical link: https://commits.webkit.org/312033@main

88be76f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 ✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation self-assigned this Apr 26, 2026
@Constellation Constellation requested a review from a team as a code owner April 26, 2026 04:42
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 26, 2026
Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 26, 2026
https://bugs.webkit.org/show_bug.cgi?id=313331
rdar://175608137

Reviewed by Sosuke Suzuki.

It is just caling a SuppressedError constructor. We should just call it
directly.

* Source/JavaScriptCore/builtins/DisposableStackPrototype.js:
(linkTimeConstant.createSuppressedError): Deleted.
* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitUsingBodyScope):

Canonical link: https://commits.webkit.org/312033@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Remove-createSuppressedError-builtin branch from 88be76f to d1ec7b5 Compare April 26, 2026 07:05
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 312033@main (d1ec7b5): https://commits.webkit.org/312033@main

Reviewed commits have been landed. Closing PR #63612 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d1ec7b5 into WebKit:main Apr 26, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants