Skip to content

[JSC] Clean up AsyncIterator asyncDispose#63627

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/JSC-Clean-up-AsyncIterator-asyncDispose
Apr 29, 2026
Merged

[JSC] Clean up AsyncIterator asyncDispose#63627
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/JSC-Clean-up-AsyncIterator-asyncDispose

Conversation

@Constellation
Copy link
Copy Markdown
Member

@Constellation Constellation commented Apr 26, 2026

69c48a2

[JSC] Clean up AsyncIterator asyncDispose
https://bugs.webkit.org/show_bug.cgi?id=313345
rdar://175616055

Reviewed by Keith Miller.

1. Make promiseReturnUndefinedOnFulfilled C++ function instead. It is
   just returning an undefined.
2. Clean up asyncDispose code. Using @newResolvedPromise /
   @newRejectedPromise helpers, and coverting entire region with
   try-catch instead.

* Source/JavaScriptCore/builtins/AsyncIteratorPrototype.js:
(overriddenName.string_appeared_here.asyncDispose):
(linkTimeConstant.promiseReturnUndefinedOnFulfilled): Deleted.
* Source/JavaScriptCore/builtins/BuiltinNames.h:
* Source/JavaScriptCore/bytecode/LinkTimeConstant.h:
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSGlobalObject::init):

Canonical link: https://commits.webkit.org/312269@main

e61cccf

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win ⏳ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
🧪 ios-wk2-wpt 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🛠 🧪 jsc 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-debug-arm64 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🧪 vision-wk2 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation self-assigned this Apr 26, 2026
@Constellation Constellation requested a review from a team as a code owner April 26, 2026 09:54
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 26, 2026
Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 28, 2026
@Constellation Constellation force-pushed the eng/JSC-Clean-up-AsyncIterator-asyncDispose branch from e703510 to e61cccf Compare April 29, 2026 04:43
@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 29, 2026
https://bugs.webkit.org/show_bug.cgi?id=313345
rdar://175616055

Reviewed by Keith Miller.

1. Make promiseReturnUndefinedOnFulfilled C++ function instead. It is
   just returning an undefined.
2. Clean up asyncDispose code. Using @newResolvedPromise /
   @newRejectedPromise helpers, and coverting entire region with
   try-catch instead.

* Source/JavaScriptCore/builtins/AsyncIteratorPrototype.js:
(overriddenName.string_appeared_here.asyncDispose):
(linkTimeConstant.promiseReturnUndefinedOnFulfilled): Deleted.
* Source/JavaScriptCore/builtins/BuiltinNames.h:
* Source/JavaScriptCore/bytecode/LinkTimeConstant.h:
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSGlobalObject::init):

Canonical link: https://commits.webkit.org/312269@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Clean-up-AsyncIterator-asyncDispose branch from e61cccf to 69c48a2 Compare April 29, 2026 07:50
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 312269@main (69c48a2): https://commits.webkit.org/312269@main

Reviewed commits have been landed. Closing PR #63627 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 69c48a2 into WebKit:main Apr 29, 2026
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants