[JSC] Clean up AsyncIterator asyncDispose#63627
Merged
webkit-commit-queue merged 1 commit intoApr 29, 2026
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash e703510) Details |
e703510 to
e61cccf
Compare
Collaborator
|
EWS run on current version of this PR (hash e61cccf) Details
|
https://bugs.webkit.org/show_bug.cgi?id=313345 rdar://175616055 Reviewed by Keith Miller. 1. Make promiseReturnUndefinedOnFulfilled C++ function instead. It is just returning an undefined. 2. Clean up asyncDispose code. Using @newResolvedPromise / @newRejectedPromise helpers, and coverting entire region with try-catch instead. * Source/JavaScriptCore/builtins/AsyncIteratorPrototype.js: (overriddenName.string_appeared_here.asyncDispose): (linkTimeConstant.promiseReturnUndefinedOnFulfilled): Deleted. * Source/JavaScriptCore/builtins/BuiltinNames.h: * Source/JavaScriptCore/bytecode/LinkTimeConstant.h: * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSGlobalObject::init): Canonical link: https://commits.webkit.org/312269@main
e61cccf to
69c48a2
Compare
Collaborator
|
Committed 312269@main (69c48a2): https://commits.webkit.org/312269@main Reviewed commits have been landed. Closing PR #63627 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
69c48a2
e61cccf
🛠 win🧪 win-tests🧪 api-mac🧪 ios-wk2-wpt🧪 api-mac-debug🧪 api-ios🛠 ios-safer-cpp🧪 mac-AS-debug-wk2🧪 mac-intel-wk2